Re: [PATCH v2] io_uring: add support for linked SQE timeouts

[Jens Axboe <axboe@kernel.dk>]

On 11/7/19 6:24 PM, Jackie Liu wrote:
>> @@ -734,11 +755,23 @@ static void io_req_link_next(struct io_kiocb *req, struct io_kiocb **nxtptr)
>> 		 * If we're in async work, we can continue processing the chain
>> 		 * in this context instead of having to queue up new async work.
>> 		 */
>> -		if (nxtptr && current_work())
>> +		if (req->flags & REQ_F_LINK_TIMEOUT) {
>> +			wake_ev = io_link_cancel_timeout(ctx, nxt);
>> +
>> +			/* we dropped this link, get next */
>> +			nxt = list_first_entry_or_null(&req->link_list,
>> +							struct io_kiocb, list);
>> +		} else if (nxtptr && current_work()) {
>> 			*nxtptr = nxt;
>> -		else
>> +			nxt = NULL;
> 
> Use 'break' is more better? no need to set variables and compare.

Fine with me, I'll make that change. Happy with it otherwise?

-- 
Jens Axboe