From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE3BC001DB for ; Mon, 7 Aug 2023 18:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbjHGSd3 (ORCPT ); Mon, 7 Aug 2023 14:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbjHGSd3 (ORCPT ); Mon, 7 Aug 2023 14:33:29 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80413171C for ; Mon, 7 Aug 2023 11:33:24 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-686f74a8992so702881b3a.1 for ; Mon, 07 Aug 2023 11:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1691433204; x=1692038004; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LGkjcKA/jaOcFZWETwKFlKnFXvZArBUGjrq9i4l1N0U=; b=eu8gj7NgXpGmJYbMHd4oAgnUNWhLwpqyDhMEOKfP6kFOADsCaMWmFeUheVyGtImGJ+ NCCNw/flrvEPD9wFID707b/GoqsAF5efKCyujuYoOX+PxjzMPMw0LDxjH4pZ1lzZMLs/ cSt+jhiyEDEVQJ9ESI5R3tYJbeJqxatMIkpKIGTddF6r7RxV7teTi4IElBJf/D1K15JD uYZeTZSZlMrXTolgEc9mz/7h6UBgcPclLt+MzbzooSxxxLh2UtkJDdIe1ulUhMhRlBtk I39WnyvPpM4bio0wub/tNgFnyaJ2CALeAsJ8RZrbjm+6+kKXPFGiZbcjqOZ45dG/ofOZ cF2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691433204; x=1692038004; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LGkjcKA/jaOcFZWETwKFlKnFXvZArBUGjrq9i4l1N0U=; b=J3ZX24iAN2gCQ93c/FQIHpvst+gJzk0Ne5RWmZTqMAkcjNF5cOLcGsY/+AYC/T8p7y +ARQ4G9lObAF6zriTbmnsjelImX8a8zLWl6vEsJOf8SFA/mHunWEMw2sgmHtDILQS+oH vSNPESm073G+O5yPHEVV5Z5n6zsqyPZpM8kje5c1iyDoOEqRJ76yPWCN+rfqb3wi1lfY a/4sU/UI/NHltFkZRwO3FvPHhhITd+LMQRR0osmiSrdU0+Tb85V8Jj9u6pAQPMMOLJno CbZNYP4OfCIyttFRvLkh96wmfLX4yZE+hFVmR/Z1yaa+SeNea4e6Hnx4n9w6KOWHc7WY /ISQ== X-Gm-Message-State: ABy/qLad2MGf1kCkSoPwjuHOE/XxSKDss6lSfqmtegYDVyT1Pzd5Zl4k jxUA7X95Ia2baQJTKh9kP5vxeQ== X-Google-Smtp-Source: APBJJlEYL/whpgikEPmMByY0tY4WLjaQW4hyn4ryLc/203BHvvkIZswyd2W8wlo6OafMT5WA2lZiJQ== X-Received: by 2002:a05:6a20:3d1e:b0:137:514a:982d with SMTP id y30-20020a056a203d1e00b00137514a982dmr35248515pzi.6.1691433204023; Mon, 07 Aug 2023 11:33:24 -0700 (PDT) Received: from [172.16.7.55] ([4.14.191.206]) by smtp.gmail.com with ESMTPSA id q2-20020a638c42000000b0055c02b8688asm5178767pgn.20.2023.08.07.11.33.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 11:33:23 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 12:33:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] io_uring/parisc: Adjust pgoff in io_uring mmap() for parisc Content-Language: en-US To: Helge Deller , Christoph Biedl , linux-parisc@vger.kernel.org, io-uring@vger.kernel.org Cc: Mike Rapoport , Vlastimil Babka References: <1691003952@msgid.manchmal.in-ulm.de> <1691349294@msgid.manchmal.in-ulm.de> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 8/7/23 12:27?PM, Helge Deller wrote: > On 8/7/23 20:24, Jens Axboe wrote: >> On 8/7/23 12:04?PM, Helge Deller wrote: >>> The changes from commit 32832a407a71 ("io_uring: Fix io_uring mmap() by >>> using architecture-provided get_unmapped_area()") to the parisc >>> implementation of get_unmapped_area() broke glibc's locale-gen >>> executable when running on parisc. >>> >>> This patch reverts those architecture-specific changes, and instead >>> adjusts in io_uring_mmu_get_unmapped_area() the pgoff offset which is >>> then given to parisc's get_unmapped_area() function. This is much >>> cleaner than the previous approach, and we still will get a coherent >>> addresss. >>> >>> This patch has no effect on other architectures (SHM_COLOUR is only >>> defined on parisc), and the liburing testcase stil passes on parisc. >> >> What branch is this against? It doesn't apply to my 6.5 io_uring branch, >> which is odd as that's where the previous commits went through. > > applies for me on git head / Linux 6.5-rc5 Hmm, maybe something unrelated then. I'll take a look. The patch is garbled fwiw, but that's nothing new. If you download the raw one from lore you can see how. -- Jens Axboe