From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D08471C3C11 for ; Wed, 19 Mar 2025 15:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742398061; cv=none; b=KqR2tp/NYx2LPkv65pE+mJGLBHvvdEQEMJ1+C8Yge1hgxKnNOv/z1lYDixUYe41yaYU5LuQZgcs+Evhpk47r1Na+zv/EywoK2QVP+3h+fVWd2QVctiYp8xajs/fzzPioiOZYO+nTR2XFHLZ/TaWGpbd6N613vqe3Ip9v2HwDCao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742398061; c=relaxed/simple; bh=ajFWxYn7pN6VZQbZWugpPVNdvdOMkJjRACF7eJSLLoc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=LET/OX5SYF7lmrzWlIUgyq+JOTWU5QbU2l2wZveJfdV37O8ehQDkLh+4pBUWYK1u+/M7mmzYpdYQ602/LAXDztPQTOZdUgg4VOqtMz/cC43dTOVqFMYhJ7la5AiIn0L5EBypMe0Kq+QZkTXRXJPrE4MeONNYjpHa78rvgqMKNZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=BAlQhS7D; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="BAlQhS7D" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-85b515e4521so215923339f.1 for ; Wed, 19 Mar 2025 08:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1742398059; x=1743002859; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Z5XI8XP6pizbR2wnq7L2d99WOMcynVJcs75IPIYppQw=; b=BAlQhS7Dm6zPUORdWPqzZAXL4vAe7RWxABO+yL2EaBDL0JJ1KyEU97HN+xd3VYQq7q UUrTdBc2vI5g9hGbfrlD3oNi5fAvBBCTEt8S/h5a5/KtSsHLYoQYk0qZbzvBxfOQwH44 vuREk4d0UvEEtqXO+ARRk55UwIfS3X2dBWq8AqzWUkEjKIs/9dDjhKniXVrc9uRzSyfk jlHoGi2w+bxJU3R6bpy75gVbfTppX3CzMfygwyFtAGMW5sAYrBv3X2DTQ8Aam7dKLgE8 zUBv+UcTB19ZCG0p0ZC4A+N13Ioj9ze+4SOqRQ7m3FaJ31s2oYsVq3jTMbzPP91Y11F9 Gqqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742398059; x=1743002859; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z5XI8XP6pizbR2wnq7L2d99WOMcynVJcs75IPIYppQw=; b=tLwnNdHbqnipe5u/ZAR3m35//gLQYEJI41hxi+Pqz0LpIDuE08MA9zrVFwrhHm3fXf 7vbN9VpZD4CfWr/LOW2orFrOjlr4pPsimAvdxY/gILYjF5QLblcWMojStQjsQ/D8n4ik iOlMSIxf4YxlVzQeLhI0r1opjRwx9s9N7+bAeBLWVcDQEGJGp7Yn0bgcjkOFUoP0QDLO f6fORtRVc/orJzerr4Xun+1mA8ouGafe/2c3VRPg6Nqg4GyfDVYLhBZJV7czw0NpSMCv jer1RIgvRK7VGb2aKun2VYbCn1opatuBD/FOfHRY0m65EqrI6o0Bt6r0BF/3NeqvdkNS QWOA== X-Forwarded-Encrypted: i=1; AJvYcCUMsViE9oLpBxDVFpLLmksI9Tru0pGZnos+vx7YdYx0R1lNqB2LL8LZVl4NzllLU3TvU9pT7sYttA==@vger.kernel.org X-Gm-Message-State: AOJu0YxWncA3CG4kxrFzKH9cZ6gTIknBLBboryzM/1vMLXBh/9elX0+s SGXeQUNVd82KPukoJQ3tfO/s95QTT0f0LLTE5suGWVHkhTMe/P3kd9uEblMrecE= X-Gm-Gg: ASbGncuMPHCLdhgYWQLBy2d6pa3maExH3T2bMcy2OcNBdXxfCmNMO4NZ+WGYY22Rnwn 12FM/C40bOtpRcTfyFOV74RgOemhOH6Pm3DtUiIS+WGWC8SOiXfDcIINKbMfr7DPqUouxzvMC0S ZAUe2BlgGxaIPzYxG5ts1Q1B/1BA+GRhY8tZVALSN4Kxuc8/EQ8YWUK4aGRJ6dgnCWys6d08frC tpre6R/VCnrH+gQbYajPUctjIbq/SikvLb0roxeguricAF6ddmN4oq+I2RmrKwncPRKZqfSGRqV PBQnkX6FvZbWNRsYK/1YWIfuO94DeO8pFuLOToMj X-Google-Smtp-Source: AGHT+IFGYzlq+PPNSs3OrQmXqUnxT0HIdylQ9a9U94OGg+zbDXr0tA1fKwH39YYPMJPyqHijFNyP3Q== X-Received: by 2002:a05:6602:3816:b0:85d:b26e:e194 with SMTP id ca18e2360f4ac-85e137e2951mr401062139f.7.1742398058991; Wed, 19 Mar 2025 08:27:38 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-85db87797dcsm309098739f.18.2025.03.19.08.27.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Mar 2025 08:27:38 -0700 (PDT) Message-ID: Date: Wed, 19 Mar 2025 09:27:37 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: (subset) [RFC PATCH v5 0/5] introduce io_uring_cmd_import_fixed_vec From: Jens Axboe To: Josef Bacik , David Sterba , Pavel Begunkov , Sidong Yang Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org References: <20250319061251.21452-1-sidong.yang@furiosa.ai> <174239798984.85082.13872425373891225169.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <174239798984.85082.13872425373891225169.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/19/25 9:26 AM, Jens Axboe wrote: > > On Wed, 19 Mar 2025 06:12:46 +0000, Sidong Yang wrote: >> This patche series introduce io_uring_cmd_import_vec. With this function, >> Multiple fixed buffer could be used in uring cmd. It's vectored version >> for io_uring_cmd_import_fixed(). Also this patch series includes a usage >> for new api for encoded read/write in btrfs by using uring cmd. >> >> There was approximately 10 percent of performance improvements through benchmark. >> The benchmark code is in >> https://github.com/SidongYang/btrfs-encoded-io-test/blob/main/main.c >> >> [...] > > Applied, thanks! > > [1/5] io_uring: rename the data cmd cache > commit: 575e7b0629d4bd485517c40ff20676180476f5f9 > [2/5] io_uring/cmd: don't expose entire cmd async data > commit: 5f14404bfa245a156915ee44c827edc56655b067 > [3/5] io_uring/cmd: add iovec cache for commands > commit: fe549edab6c3b7995b58450e31232566b383a249 > [4/5] io_uring/cmd: introduce io_uring_cmd_import_fixed_vec > commit: b24cb04c1e072ecd859a98b2e4258ca8fe8d2d4d 1-4 look pretty straight forward to me - I'll be happy to queue the btrfs one as well if the btrfs people are happy with it, just didn't want to assume anything here. -- Jens Axboe