From: Xiaoguang Wang <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH v5 2/2] io_uring: avoid unnecessary io_wq_work copy for fast poll feature
Date: Tue, 2 Jun 2020 09:16:42 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
hi Jens, Pavel,
Will you have a look at this V5 version? Or we hold on this patchset, and
do the refactoring work related io_wq_work firstly.
Regards,
Xiaoguang Wang
> Basically IORING_OP_POLL_ADD command and async armed poll handlers
> for regular commands don't touch io_wq_work, so only REQ_F_WORK_INITIALIZED
> is set, can we do io_wq_work copy and restore.
>
> Signed-off-by: Xiaoguang Wang <[email protected]>
> ---
> V3:
> drop the REQ_F_WORK_NEED_RESTORE flag introduced in V2 patch, just
> use REQ_F_WORK_INITIALIZED to control whether to do io_wq_work copy
> and restore.
> ---
> fs/io_uring.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 8e022d0f0c86..b761ef7366f9 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -4527,7 +4527,8 @@ static void io_async_task_func(struct callback_head *cb)
> spin_unlock_irq(&ctx->completion_lock);
>
> /* restore ->work in case we need to retry again */
> - memcpy(&req->work, &apoll->work, sizeof(req->work));
> + if (req->flags & REQ_F_WORK_INITIALIZED)
> + memcpy(&req->work, &apoll->work, sizeof(req->work));
> kfree(apoll);
>
> if (!canceled) {
> @@ -4624,7 +4625,8 @@ static bool io_arm_poll_handler(struct io_kiocb *req)
> return false;
>
> req->flags |= REQ_F_POLLED;
> - memcpy(&apoll->work, &req->work, sizeof(req->work));
> + if (req->flags & REQ_F_WORK_INITIALIZED)
> + memcpy(&apoll->work, &req->work, sizeof(req->work));
> had_io = req->io != NULL;
>
> get_task_struct(current);
> @@ -4649,7 +4651,8 @@ static bool io_arm_poll_handler(struct io_kiocb *req)
> if (!had_io)
> io_poll_remove_double(req);
> spin_unlock_irq(&ctx->completion_lock);
> - memcpy(&req->work, &apoll->work, sizeof(req->work));
> + if (req->flags & REQ_F_WORK_INITIALIZED)
> + memcpy(&req->work, &apoll->work, sizeof(req->work));
> kfree(apoll);
> return false;
> }
> @@ -4694,7 +4697,9 @@ static bool io_poll_remove_one(struct io_kiocb *req)
> * io_req_work_drop_env below when dropping the
> * final reference.
> */
> - memcpy(&req->work, &apoll->work, sizeof(req->work));
> + if (req->flags & REQ_F_WORK_INITIALIZED)
> + memcpy(&req->work, &apoll->work,
> + sizeof(req->work));
> kfree(apoll);
> }
> }
>
next prev parent reply other threads:[~2020-06-02 1:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 14:39 [PATCH v4 1/2] io_uring: avoid whole io_wq_work copy for requests completed inline Xiaoguang Wang
2020-05-30 14:39 ` [PATCH v4 2/2] io_uring: avoid unnecessary io_wq_work copy for fast poll feature Xiaoguang Wang
2020-05-30 16:44 ` [PATCH v4 1/2] io_uring: avoid whole io_wq_work copy for requests completed inline Jens Axboe
2020-05-30 17:14 ` Jens Axboe
2020-05-30 17:29 ` Jens Axboe
2020-05-30 17:36 ` Pavel Begunkov
2020-05-31 13:57 ` Xiaoguang Wang
2020-05-31 14:49 ` Pavel Begunkov
2020-05-31 14:12 ` Xiaoguang Wang
2020-05-31 14:31 ` Xiaoguang Wang
2020-05-31 14:57 ` Pavel Begunkov
2020-05-31 16:15 ` Xiaoguang Wang
2020-06-01 10:43 ` Pavel Begunkov
2020-06-01 11:50 ` Xiaoguang Wang
2020-06-01 4:56 ` [PATCH v5 " Xiaoguang Wang
2020-06-01 4:56 ` [PATCH v5 2/2] io_uring: avoid unnecessary io_wq_work copy for fast poll feature Xiaoguang Wang
2020-06-02 1:16 ` Xiaoguang Wang [this message]
2020-06-03 13:46 ` Pavel Begunkov
2020-06-07 15:02 ` Jens Axboe
2020-06-07 20:36 ` Pavel Begunkov
2020-06-07 20:57 ` Pavel Begunkov
2020-06-07 23:29 ` Jens Axboe
2020-06-08 7:43 ` Pavel Begunkov
2020-06-08 12:14 ` Xiaoguang Wang
2020-06-08 20:08 ` Jens Axboe
2020-06-07 23:26 ` Jens Axboe
2020-05-31 14:33 ` [PATCH v4 1/2] io_uring: avoid whole io_wq_work copy for requests completed inline Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c648e7-f154-f4eb-586f-841f08b845fd@linux.alibaba.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox