From: Jens Axboe <[email protected]>
To: Bob Liu <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 1/2] fs:io_uring: clean up io_uring_cancel_files
Date: Wed, 13 Nov 2019 12:37:46 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/13/19 3:06 AM, Bob Liu wrote:
> return val is not used, drop it.
> Also drop unnecessary if (cancel_req).
Applied both of these, reworded the commit messages a bit. Thanks for
sending them in. A few notes for next time:
- Please use a cover letter if you send more than 1 patch
- Patch subject should be "io_uring: bla bla", no fs, and use the same
style for both (you have fs:io_uring and fs: io_uring
--
Jens Axboe
prev parent reply other threads:[~2019-11-13 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:06 [PATCH 1/2] fs:io_uring: clean up io_uring_cancel_files Bob Liu
2019-11-13 10:06 ` [PATCH 2/2] fs: io_uring: introduce req_need_defer() Bob Liu
2019-11-13 19:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox