public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: John Garry <[email protected]>,
	io-uring <[email protected]>
Subject: Re: [PATCH] io_uring/rw: ensure reissue path is correctly handled for IOPOLL
Date: Thu, 6 Mar 2025 04:33:30 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 3/6/25 3:12 AM, John Garry wrote:
> On 05/03/2025 21:06, Jens Axboe wrote:
>> The IOPOLL path posts CQEs when the io_kiocb is marked as completed,
>> so it cannot rely on the usual retry that non-IOPOLL requests do for
>> read/write requests.
>>
>> If -EAGAIN is received and the request should be retried, go through
>> the normal completion path and let the normal flush logic catch it and
>> reissue it, like what is done for !IOPOLL reads or writes.
>>
>> Fixes: d803d123948f ("io_uring/rw: handle -EAGAIN retry at IO completion time")
>> Reported-by: John Garry<[email protected]>
>> Link:https://urldefense.com/v3/__https://lore.kernel.org/io- uring/[email protected]/__;!! ACWV5N9M2RV99hQ!J4rCZomS7jntxigOWFGkQC3hFMb5EZf3-aZG4hZCB6n_quTKHse9g- WSxf46gMXpEfyzjaAQKTff2J9o0pg$ Signed-off-by: Jens Axboe<[email protected]>
> 
> This solves the issue which I was seeing, so:
> 
> Tested-by: John Garry <[email protected]>

Great, thanks for testing!

-- 
Jens Axboe


      reply	other threads:[~2025-03-06 11:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 21:06 [PATCH] io_uring/rw: ensure reissue path is correctly handled for IOPOLL Jens Axboe
2025-03-06 10:12 ` John Garry
2025-03-06 11:33   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox