From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [DRAFT liburing] man: document new register/update API
Date: Tue, 31 Aug 2021 11:00:49 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/31/21 10:38 AM, Pavel Begunkov wrote:
> On 8/28/21 8:35 PM, Jens Axboe wrote:
>> On 8/28/21 1:18 PM, Pavel Begunkov wrote:
>>> Document
>>> - IORING_REGISTER_FILES2
>>> - IORING_REGISTER_FILES_UPDATE2,
>>> - IORING_REGISTER_BUFFERS2
>>> - IORING_REGISTER_BUFFERS_UPDATE,
>>>
>>> And add a couple of words on registered resources (buffers, files)
>>> tagging.
>>
>> Just a few comments below.
>
> Thanks for taking a look, not going to pretend that I'm good at it :)
>
> [...]
>
>>> +.PP
>>> +.in +8n
>>> +.EX
>>> +struct io_uring_rsrc_register {
>>> + __u32 nr;
>>> + __u32 resv;
>>> + __u64 resv2;
>>> + __aligned_u64 data;
>>> + __aligned_u64 tags;
>>> +};
>>
>> Move this up to where it's initially mentioned?
>
> Do you mean a couple of lines up? like this?
Yeah, just move it where it's first described.
--
Jens Axboe
prev parent reply other threads:[~2021-08-31 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 19:18 [DRAFT liburing] man: document new register/update API Pavel Begunkov
2021-08-28 19:35 ` Jens Axboe
2021-08-31 16:38 ` Pavel Begunkov
2021-08-31 17:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox