From: Jens Axboe <[email protected]>
To: Jiufei Xue <[email protected]>,
Stefan Metzmacher <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH liburing v2 1/2] io_uring_enter: add timeout support
Date: Tue, 4 Aug 2020 19:43:37 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/4/20 7:08 PM, Jiufei Xue wrote:
>
>
> On 2020/8/4 下午6:25, Stefan Metzmacher wrote:
>> Am 04.08.20 um 11:21 schrieb Jiufei Xue:
>>> Kernel can handle timeout when feature IORING_FEAT_GETEVENTS_TIMEOUT
>>> supported. Applications should use io_uring_set_cqwait_timeout()
>>> explicitly to asked for the new feature.
>>>
>>> In addition in this commit we add two new members to io_uring and a pad
>>> for future flexibility. So for the next release, applications have to
>>> re-compile against the lib.
>>
>> I don't think this is an option, existing applications need to work.
>>
>> Or they must fail at startup when the runtime dependencies are resolved.
>> Which means the soname of the library has to change.
>>
>
> Yes, I think the version should bump to 2.0.X with next release.
>
> Jens,
> should I bump the version with this patch set? Or you will bump it
> before next release.
It should get bumped with the change, otherwise things will fail before
the next release in case people run the git version.
And while you're at it, add some more pad. Don't want to go through
the same process again the next time we need a bit of space. Just add
4 unsigneds as pad at least, that's enough for a pointer and 2
32-bit entries.
--
Jens Axboe
next prev parent reply other threads:[~2020-08-05 1:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 9:21 [PATCH liburing v2 0/2] add support for new timeout feature Jiufei Xue
2020-08-04 9:21 ` [PATCH liburing v2 1/2] io_uring_enter: add timeout support Jiufei Xue
2020-08-04 10:25 ` Stefan Metzmacher
2020-08-05 1:08 ` Jiufei Xue
2020-08-05 1:43 ` Jens Axboe [this message]
2020-08-05 2:00 ` Jiufei Xue
2020-08-04 9:21 ` [PATCH liburing v2 2/2] test/timeout: add testcase for new timeout feature Jiufei Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox