From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA60C43331 for ; Wed, 10 Feb 2021 12:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C85E564E40 for ; Wed, 10 Feb 2021 12:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbhBJL7x (ORCPT ); Wed, 10 Feb 2021 06:59:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231373AbhBJL5p (ORCPT ); Wed, 10 Feb 2021 06:57:45 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB58C061574 for ; Wed, 10 Feb 2021 03:56:48 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id h12so2171906wrw.6 for ; Wed, 10 Feb 2021 03:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nrnsvo+6Dnt9COqtrkNWblqJLKZDhKJ3teO87Ft0pn8=; b=PyZtn/my1Q4ZawijAIDHGenciLHpBuygSfheeihPlBo87Q7sRjO/9+xYBHP5TzLlu/ PVK4xH/015JWR7o0+WOfugvl299j47/5aSw54zI22U7CVgCaLi/cBOBH72R7tjI39jFy QgJlCc6vpDrcxxoeloRhgzFzeGRH2I07ELr9bRotXzak4OXljBMBdVBHA/9Y/ieIw7mz 3Q4NAdvGV+Pzo3SeD6xPC2EbMDQnQ0OtJAVzgTt9/gNtjJBr2jTMh1CdhGFIvd7Aj7va yZbfZ0W3SVuAcqVYgCKlzIelzqQST9WWUSI6exrRre6Bq6OpT7CSvK3XIgDpUkD3Y5L7 09Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nrnsvo+6Dnt9COqtrkNWblqJLKZDhKJ3teO87Ft0pn8=; b=NqVKLCtlPXWryiZ4ZAqb/mUx3TIqUhJQlI5UA1cqv9BXI5NlpgwJau7/TMM+ACtGB6 whNUiJQDVRSPuhLG9hcxzzXmv9+DO/3Bd1pyTpeg1Hu7neydkxfsMNh6kq5PkXppIGrD 2nXCA8HjUxo6bOlEqgEmkla7qVhIqcBXlrIJBXgkiCBUEWuJ6zSuTipr6a9W0coiSR8n rvpI+txBC5r+4Sm7MN3utK3fTbR4xdv1dri8/Sb/Xza8LrR9Y0brbcT8bMoFSf2o+HeL 3FTyXECUC3X1Q8PSUmxRJNoNzSsFmrcYGVNSF9VUv7WfS0uTGtySVLMbNshC6sakDTDf DGgg== X-Gm-Message-State: AOAM533XNRAfvGAqE01ChKoKLzBcZ5Bf+pmKXx64Bprdq0NuMZaTe8hf vyPiqcu1uo1jAOW5Mk/dNvZqBXUwaxOyGg== X-Google-Smtp-Source: ABdhPJwLO5zBCKOcMcNfY/fP8z9YsHbh8IfzTelkakTePZgCnma79OsvdnlfSxHT9mLm54nUTCIPkQ== X-Received: by 2002:a05:6000:1815:: with SMTP id m21mr3211743wrh.350.1612958207447; Wed, 10 Feb 2021 03:56:47 -0800 (PST) Received: from [192.168.8.194] ([148.252.132.126]) by smtp.gmail.com with ESMTPSA id i20sm2027707wmq.7.2021.02.10.03.56.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Feb 2021 03:56:47 -0800 (PST) To: Jens Axboe , io-uring@vger.kernel.org References: From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: [PATCH RFC 00/17] playing around req alloc Message-ID: Date: Wed, 10 Feb 2021 11:53:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/02/2021 03:23, Jens Axboe wrote: > On 2/9/21 8:14 PM, Pavel Begunkov wrote: >> On 10/02/2021 02:08, Jens Axboe wrote: >>> On 2/9/21 5:03 PM, Pavel Begunkov wrote: >>>> Unfolding previous ideas on persistent req caches. 4-7 including >>>> slashed ~20% of overhead for nops benchmark, haven't done benchmarking >>>> personally for this yet, but according to perf should be ~30-40% in >>>> total. That's for IOPOLL + inline completion cases, obviously w/o >>>> async/IRQ completions. >>> >>> And task_work, which is sort-of inline. >>> >>>> Jens, >>>> 1. 11/17 removes deallocations on end of submit_sqes. Looks you >>>> forgot or just didn't do that. >> >> And without the patches I added, it wasn't even necessary, so >> nevermind > > OK good, I was a bit confused about that one... > >>>> 2. lists are slow and not great cache-wise, that why at I want at least >>>> a combined approach from 12/17. >>> >>> This is only true if you're browsing a full list. If you do add-to-front >>> for a cache, and remove-from-front, then cache footprint of lists are >>> good. >> >> Ok, good point, but still don't think it's great. E.g. 7/17 did improve >> performance a bit for me, as I mentioned in the related RFC. And that >> was for inline-completed nops, and going over the list/array and >> always touching all reqs. > > Agree, array is always a bit better. Just saying that it's not a huge > deal unless you're traversing the list, in which case lists are indeed > horrible. But for popping off the first entry (or adding one), it's not > bad at all. btw, looks can be replaced with a singly-linked list (stack). > >>>> 3. Instead of lists in "use persistent request cache" I had in mind a >>>> slightly different way: to grow the req alloc cache to 32-128 (or hint >>>> from the userspace), batch-alloc by 8 as before, and recycle _all_ reqs >>>> right into it. If overflows, do kfree(). >>>> It should give probabilistically high hit rate, amortising out most of >>>> allocations. Pros: it doesn't grow ~infinitely as lists can. Cons: there >>>> are always counter examples. But as I don't have numbers to back it, I >>>> took your implementation. Maybe, we'll reconsider later. >>> >>> It shouldn't grow bigger than what was used, but the downside is that >>> it will grow as big as the biggest usage ever. We could prune, if need >>> be, of course. >> >> Yeah, that was the point. But not a deal-breaker in either case. > > Agree > >>> As far as I'm concerned, the hint from user space is the submit count. >> >> I mean hint on setup, like max QD, then we can allocate req cache >> accordingly. Not like it matters > > I'd rather grow it dynamically, only the first few iterations will hit > the alloc. Which is fine, and better than pre-populating. Assuming I > understood you correctly here... I guess not, it's not about number of requests perse, but space in alloc cache. Like that struct io_submit_state { ... void *reqs[userspace_hint]; }; > >>> >>>> I'll revise tomorrow on a fresh head + do some performance testing, >>>> and is leaving it RFC until then. >>> >>> I'll look too and test this, thanks! > > Tests out good for me with the suggested edits I made. nops are > massively improved, as suspected. But also realistic workloads benefit > nicely. > > I'll send out a few patches I have on top tomorrow. Not fixes, but just > further improvements/features/accounting. Sounds great! btw, "lock_free_list" which is not a "lock-free" list can be confusing, I'd suggest to rename it to free_list_lock. -- Pavel Begunkov