From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8444DC433DF for ; Thu, 18 Jun 2020 08:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CB96204EA for ; Thu, 18 Jun 2020 08:32:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lightnvm-io.20150623.gappssmtp.com header.i=@lightnvm-io.20150623.gappssmtp.com header.b="VeZchB1Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728406AbgFRIcL (ORCPT ); Thu, 18 Jun 2020 04:32:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728680AbgFRIcC (ORCPT ); Thu, 18 Jun 2020 04:32:02 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAFA0C0613EE for ; Thu, 18 Jun 2020 01:32:01 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id b6so5070652wrs.11 for ; Thu, 18 Jun 2020 01:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=mBaOTic59RjsjLgo2G8JEZ2HjlmP5tRj9DOckjIFG3U=; b=VeZchB1Zk+81qlHhjvzg9LHD2TBm3ByGBy0IW8ORikdh0NwKJNt9P+kqDslvMSk8SW nw6/o4F3Qx8D4bVOI2IfZ8m1HhI57HG0Hg2hsWb4vVk65rZ6pzUgW4hpY/6HTTXzKFdC NMqgGuUBaGfuv0iTTGMcyXJYvYBSsw79YzG0M47LU23y2Akz4LEVPk1bFN9SVP9Ah+Qq xv5s2DSDOEC1vdjyoTIdHq3HLLEG6tnDZdPLqGpNCtH1KfYSZsnsmu65lt61g5qsxtk9 tNk90RsdiXSIUxAFNTAEUhx/jhs/r0f5LxK0bU6VAb6V8yPKshxlErMCndviPPQOs6c+ LH/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mBaOTic59RjsjLgo2G8JEZ2HjlmP5tRj9DOckjIFG3U=; b=c4LtbAE3WoKAt//nOFmJZULrniBW7t22T5UrqYMnd5Uiqj+JZ/ZzGN3ZGdB9cPkHWc UwmRZX1drOtpuQOfylRWdqDw5UiEFxfaiMQiu1Av6ShYZgKRbFkaJtKKcdVsnYTCvo0W 4Z7INFEQs44GZ+G2FXAXnU76eWQvk37tAZ8/9JEQcMmECsZ1WibVk29muXSvhvkLGz+8 uqH803X2l1sviXUawSiXstf9HUdp/q1jmQ+ke8MB7tGvCC42PAQ8CKzm/jS0rc59YLVj kWnm8iqse2PqmG47L1wG0P+PidpufFYB+UPM3mNuI3buNrk0Sdskrmhu0LUchk3xBPjO w7UA== X-Gm-Message-State: AOAM533fx2AyiRwPfFXW+8iLEK08gGVm989TeD2mmWlq7Dsqm5B2yHMr 1F0EjUOhBc6AHOuG2PDAvqUQOQ== X-Google-Smtp-Source: ABdhPJxf+HN7+JKdkPYOEHori7/i1a/eK+R6a+pu586zPO/RkLdukssOlIov8whQrf/rt2dWqJEzYw== X-Received: by 2002:adf:a306:: with SMTP id c6mr3397910wrb.122.1592469120621; Thu, 18 Jun 2020 01:32:00 -0700 (PDT) Received: from [10.0.0.6] (xb932c246.cust.hiper.dk. [185.50.194.70]) by smtp.gmail.com with ESMTPSA id t14sm2653507wrb.94.2020.06.18.01.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 01:32:00 -0700 (PDT) Subject: Re: [PATCH 0/3] zone-append support in aio and io-uring To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= Cc: Kanchan Joshi , axboe@kernel.dk, viro@zeniv.linux.org.uk, bcrl@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, selvakuma.s1@samsung.com, nj.shetty@samsung.com, Damien Le Moal , Keith Busch , Christoph Hellwig References: <1592414619-5646-1-git-send-email-joshi.k@samsung.com> <20200618082740.i4sfoi54aed6sxnk@mpHalley.local> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: Date: Thu, 18 Jun 2020 10:32:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200618082740.i4sfoi54aed6sxnk@mpHalley.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 18/06/2020 10.27, Javier González wrote: > On 18.06.2020 10:04, Matias Bjørling wrote: >> On 17/06/2020 19.23, Kanchan Joshi wrote: >>> This patchset enables issuing zone-append using aio and io-uring >>> direct-io interface. >>> >>> For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application >>> uses start LBA >>> of the zone to issue append. On completion 'res2' field is used to >>> return >>> zone-relative offset. >>> >>> For io-uring, this introduces three opcodes: >>> IORING_OP_ZONE_APPEND/APPENDV/APPENDV_FIXED. >>> Since io_uring does not have aio-like res2, cqe->flags are >>> repurposed to return zone-relative offset >> >> Please provide a pointers to applications that are updated and ready >> to take advantage of zone append. > > Good point. We are posting a RFC with fio support for append. We wanted > to start the conversation here before. > > We can post a fork for improve the reviews in V2. Christoph's response points that it is not exactly clear how this matches with the POSIX API. fio support is great - but I was thinking along the lines of applications that not only benchmark performance. fio should be part of the supported applications, but should not be the sole reason the API is added.