From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F7DC5479D for ; Mon, 9 Jan 2023 03:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236637AbjAIDxt (ORCPT ); Sun, 8 Jan 2023 22:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236710AbjAIDxA (ORCPT ); Sun, 8 Jan 2023 22:53:00 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A951011823 for ; Sun, 8 Jan 2023 19:51:54 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id jl4so8177621plb.8 for ; Sun, 08 Jan 2023 19:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aPLGdbD4w3KTNSXThRBpSsjS7f9R9UPFXQ4iA1FrtvI=; b=nPPmYnBXei1dfYlS1rdCM2vB2N1VwVs01sjf7uRRBjye8S+HOHefmxparAACWmM1WD aMAqF3SCZOzl/6oJTTay0ycDo1Ce165iGmwv5opji1Y6bgcUmowgU1bWuGmeTs7+0fC7 dVIm84RuDd6Qv5ScegEDxJb3PaVDGCdI8kvbcg9J86poaHNp0BG+RUkTuiSUV5bJV9CA OyMoDvJL2A9BS40+lDXlmJ50fkeRkDrnadxJj6Ao0uevnhSxWcUA17SJXJUIZxeL+ATh 2pixxWYOSXnYEoRO56vtmDsE3RuMTL6f7SWYn/44iQ6FfkTjVHT0g9Cb1nSnJjYtS6Q6 ftiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aPLGdbD4w3KTNSXThRBpSsjS7f9R9UPFXQ4iA1FrtvI=; b=2H4wtKr/Gn/wWVWISJq9fAlTVfU2LzEntmKIwFnJAD+2YxdNhEOznYx7IRvTEuBasR AGl2yhV36pI+UdOag7KMC4g//OyMAWxws5WnL+CJmgR8agKm3azEuC80bME1e/DP19ii gX3/QM5ezRIWuKrus6IpOzf4c46w5E/QBBdl44lUYlbuLzkCR0gSkAt9dLNra1eOwfqH a3DCEc2JP9jyHswhUkwt2gQcSN2qwlIXhZK7NP3EW/5zOxAVzJYYBPSRHzWW/USeo67w syMYBAi0sAmpGdzb59NHIu913iyTgv7oPxvgPzyO5fatiKLGYxPETrczGHY+RezxCSV0 wP0Q== X-Gm-Message-State: AFqh2kqxfHMEhE+HfXNePnf2mgTzDZnE9fIeNijw+g5uS+UYrxIMoy5f N+quakxanlYC43GCr4qJfEQXpw== X-Google-Smtp-Source: AMrXdXsHyCuK/5tTYQ2YiGIo2OlMLfna9+NQYVqCDBdoVnrK+eAv9N2c36+OrrMuRoh4EdIDp1Zslw== X-Received: by 2002:a17:902:a512:b0:192:5c3e:8952 with SMTP id s18-20020a170902a51200b001925c3e8952mr14756022plq.2.1673236305856; Sun, 08 Jan 2023 19:51:45 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z3-20020a6552c3000000b0049b7b1205a0sm4278560pgp.54.2023.01.08.19.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Jan 2023 19:51:45 -0800 (PST) Message-ID: Date: Sun, 8 Jan 2023 20:51:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Content-Language: en-US To: Keith Busch , linux-kernel@vger.kernel.org, Alexander Viro Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, hch@lst.de, io-uring@vger.kernel.org, Pavel Begunkov , Eric Dumazet , Steven Rostedt , davem@davemloft.net, Jakub Kicinski , Paolo Abeni , David Howells , Jarkko Sakkinen , Paul Moore , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, Keith Busch References: <20230105190741.2405013-1-kbusch@meta.com> From: Jens Axboe In-Reply-To: <20230105190741.2405013-1-kbusch@meta.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/5/23 12:07 PM, Keith Busch wrote: > From: Keith Busch > > ITER_UBUF is a more efficient representation when using single vector > buffers, providing small optimizations over ITER_IOVEC. This series > introduces a helper to set these up, and replaces all applicable users > of import_single_range with the new helper. And since there are no > single range users left after this change, the helper is no longer > needed. > > As noted in v1(*), there are some fundamental differences to how io_uring > compares to read/write/readv/writev. There are only the two affected > file_operations, and they already do not work with io_uring due to their > diverging semantics for vectored vs non-vectored read/write. Therefore, > this series having io_uring prefer ubuf iov_iter isn't introducing new > breakage. Pondering how to stage this, both for later upstream but also for testing. Would probably make the best sense to stage 1-5 separately, and then just punt the remaining ones to the appropriate subsystems. And then 12/12 can go in when they have all been applied. -- Jens Axboe