public inbox for [email protected]
 help / color / mirror / Atom feed
From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCHSET 0/2] Add support for IORING_RECVSEND_POLL_FIRST
Date: Wed, 27 Apr 2022 11:57:19 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

在 4/27/22 9:54 AM, Jens Axboe 写道:
> Hi,
> 
> I had a re-think on the flags2 addition [1] that was posted earlier
> today, and I don't really like the fact that flags2 then can't work
> with ioprio for read/write etc. We might also want to extend the
> ioprio field for other types of IO in the future.
> 
> So rather than do that, do a simpler approach and just add an io_uring
> specific flag set for send/recv and friends. This then allow setting
> IORING_RECVSEND_POLL_FIRST in sqe->addr2 for those, and if set, io_uring
> will arm poll first rather than attempt a send/recv operation.
> 
> [1] https://lore.kernel.org/io-uring/[email protected]/
> 
Looks good to me,

Reviewed-by: Hao Xu <[email protected]>

  parent reply	other threads:[~2022-04-27  3:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  1:54 [PATCHSET 0/2] Add support for IORING_RECVSEND_POLL_FIRST Jens Axboe
2022-04-27  1:54 ` [PATCH 1/2] io_uring: check IOPOLL/ioprio support upfront Jens Axboe
2022-04-27  1:54 ` [PATCH 2/2] io_uring: add POLL_FIRST support for send/sendmsg and recv/recvmsg Jens Axboe
2022-04-27  3:57 ` Hao Xu [this message]
2022-04-29 18:31 ` [PATCHSET 0/2] Add support for IORING_RECVSEND_POLL_FIRST Hao Xu
2022-04-29 18:40   ` Hao Xu
2022-04-29 18:44     ` Jens Axboe
2022-04-29 18:44   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox