From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77EE8C001B0 for ; Mon, 24 Jul 2023 18:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbjGXSWL (ORCPT ); Mon, 24 Jul 2023 14:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjGXSWK (ORCPT ); Mon, 24 Jul 2023 14:22:10 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0D910C3 for ; Mon, 24 Jul 2023 11:22:09 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-348de7bc865so239225ab.0 for ; Mon, 24 Jul 2023 11:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1690222928; x=1690827728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZlGqwdb6bAoylkqLXqRNncq4LrSVbEkxLHu0eBS0UCo=; b=SbDqTYDYrGfwh+e6v+ZS5/BSB8MarGS6nvaJI+QlbYAw4Qhj0G4GRSrfEA51SabuqI 4qyzgUnfiTSx5pVPmcKrI6NZQla58YVwtZYp5dBlDehg8aQbe92/u2zNzzHTrAiemJn7 C0yWsFFzvZ8MWmAA/QgDuKf7th0nR81ICYUISmqDm4Yd3KwwfF1vIKIi3VLPvLZ627y7 dag0yJM6fnek3ENIuSi9GTCkiTDdsLEBbpGc/ARu0IsY5PtBGK3QvEV26kxN5lm5BGIL BcgDZh3T5AH/3uCsGeROBYGnSzWDnV8WvZPq0z1u/gwLdBwhTA3CYtguTHCiJomGOcHH MZCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690222928; x=1690827728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZlGqwdb6bAoylkqLXqRNncq4LrSVbEkxLHu0eBS0UCo=; b=cmnIFq46JI08Jy/tPApbaOTrDzUwg4Ot0dGQ1jEAY9P14S5+WbjKCIc6//JSuVIxDI N6JKLTp/4ETXsIB8ii0JSi/PqO1nQ2HBga2gJMe+b/OKqxeaZtozYVdsSVlZbfzdbyD9 Sg3meJEcXyL4MyLBwfVZ5sc1+TuTbAvryBxC6KeyUTutpg7DK2vY0QlBz9RMsLHBApD6 ZWeRu9z5W+8EJSyyDtxg7G5AFwMUh8WH+Gs50Mq3PYjjpxxW7wtKmpQ7IES5MJJrrohH g4KlR3XbovozJLlVkjHLDI1uFbD1OMeEzGlkJrujCbbOYeoArteasv8NfyQOB9xN2PB1 34fA== X-Gm-Message-State: ABy/qLaX6pXz6YHqywVZeuxfUjjuuzSu8UliR1samiGbia30n8d1uV4W UQG0hWpT28g68L9Rr+bZJfV+ig== X-Google-Smtp-Source: APBJJlGOaq3eY9t8T7Eh1q/nPBtpvZXB+aZaoDKkzrXd7wpYNzUQxjZqSuSQRfhk2xfUsDEgn7j0cw== X-Received: by 2002:a05:6602:3e87:b0:780:cb36:6f24 with SMTP id el7-20020a0566023e8700b00780cb366f24mr8633262iob.2.1690222928696; Mon, 24 Jul 2023 11:22:08 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c20-20020a5d9754000000b00760e7a343c1sm3521048ioo.30.2023.07.24.11.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 11:22:08 -0700 (PDT) Message-ID: Date: Mon, 24 Jul 2023 12:22:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] io_uring: Use io_schedule* in cqring wait Content-Language: en-US To: Phil Elwell Cc: Greg KH , andres@anarazel.de, asml.silence@gmail.com, david@fromorbit.com, hch@lst.de, io-uring@vger.kernel.org, LKML , linux-xfs@vger.kernel.org, stable References: <2023072438-aftermath-fracture-3dff@gregkh> <140065e3-0368-0b5d-8a0d-afe49b741ad2@kernel.dk> <0ae07b66-956a-bb62-e4e8-85fa5f72362f@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 7/24/23 10:48 AM, Phil Elwell wrote: > Hi Jens, > > On Mon, 24 Jul 2023 at 17:08, Jens Axboe wrote: >> >> On 7/24/23 10:07?AM, Phil Elwell wrote: >>>> Even though I don't think this is an actual problem, it is a bit >>>> confusing that you get 100% iowait while waiting without having IO >>>> pending. So I do think the suggested patch is probably worthwhile >>>> pursuing. I'll post it and hopefully have Andres test it too, if he's >>>> available. >>> >>> If you CC me I'll happily test it for you. >> >> Here it is. > > < snip > > > Thanks, that works for me on top of 6.5-rc3. Going to 6.1 is a > non-trivial (for me) back-port - the switch from "ret = 0" in 6.5 to > "ret = 1" in 6.1 is surprising. Great, thanks for testing. I'll take care of the stable backports once the patch lands in upstream -git later this week. -- Jens Axboe