From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265DEC34056 for ; Wed, 19 Feb 2020 20:29:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4E5B208C4 for ; Wed, 19 Feb 2020 20:29:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=scylladb-com.20150623.gappssmtp.com header.i=@scylladb-com.20150623.gappssmtp.com header.b="vIQromgs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgBSU3b (ORCPT ); Wed, 19 Feb 2020 15:29:31 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:44005 "EHLO mail-wr1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgBSU3b (ORCPT ); Wed, 19 Feb 2020 15:29:31 -0500 Received: by mail-wr1-f51.google.com with SMTP id r11so2068998wrq.10 for ; Wed, 19 Feb 2020 12:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DjvDdDQvKCcCx95f1Jn6XuJl7luFA74PtLM2eMCOOdA=; b=vIQromgsflTjOMfZT6KZPJTyp767HV76U/OCu/gSmdr45zHMv8cYuc/SC+SIx9HucN bs+hEw/yZSi85Qe44tQZdn5Li5L13b+PwmjM0EVGoCKXpWsTX3af9srUQ14NBdU0p/eS ZCg0WSMnosn7f8bbbm/Uc2J07ZIezS/np4yTCBK31E9iBXORXbIrqVXjxOsw+3brZ7ce AbtmIM7RbhV5QddkfPWONRxcNSQ2XCnjut3HrZsf4SM34OYgIWLQOHOvXWDU4q5hGQMN 1IIyBzIICnHNGjek5i+si1CI5AdZ2MoFIY1Ooro5p8eaoD2SBgt8dopmgh5uD0D5D8MT 2NnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=DjvDdDQvKCcCx95f1Jn6XuJl7luFA74PtLM2eMCOOdA=; b=TP4tjDhmkobin2wgli3/55ZsMY5wYLr/TtZK+47V2Te+mWhf5va/HN/b5dSDeBWbbJ Qzd4iqJISAjUp5pyemkiIXx8laSp0iciFbY/nkEgB/XzoI9EaNG/4Y4YGEAfr8Eeoq8Z y0zR1Oqw5y81Ne+3q7wmg+Y3ajnXs6sQPYKJCVVPRuKGj+lFTuCsNMCadppyMt0b4MQ+ dDEB/vSdBT/0mO+e4qoU7hRO596tv9HV85MS6i0uIVLl37uaYBB+IFt86C6UgjqerUNR L9RhEr/XFzK+glv5bBUXnM1z3E+ZC6+kGj4hvGweH22F6+AvPCuiX32DZTd6Iwb1CCOn ankg== X-Gm-Message-State: APjAAAUhXhloHGaZ2a4XxE55VnxzgmnuUek6uaetPqIOjC7QMdUkRxhG hrQN+v5Is6y4CyUI/RhEbdn0yA== X-Google-Smtp-Source: APXvYqxRHwAt1gvdQpOSwsRgLfau8ahO1z9Z6wH/eKAG1my0aQ1WUX2BwUmjd0wz3MzjOR6XSRn/pQ== X-Received: by 2002:adf:b254:: with SMTP id y20mr37094627wra.362.1582144169794; Wed, 19 Feb 2020 12:29:29 -0800 (PST) Received: from tmp.scylladb.com (bzq-79-178-26-168.red.bezeqint.net. [79.178.26.168]) by smtp.googlemail.com with ESMTPSA id z19sm1102464wmi.43.2020.02.19.12.29.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2020 12:29:28 -0800 (PST) Subject: Re: crash on accept To: Glauber Costa , Jens Axboe Cc: io-uring@vger.kernel.org References: From: Avi Kivity Message-ID: Date: Wed, 19 Feb 2020 22:29:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/19/20 10:25 PM, Glauber Costa wrote: > On Wed, Feb 19, 2020 at 3:13 PM Jens Axboe wrote: >> On 2/19/20 1:11 PM, Glauber Costa wrote: >>> On Wed, Feb 19, 2020 at 3:09 PM Jens Axboe wrote: >>>> On 2/19/20 9:23 AM, Glauber Costa wrote: >>>>> Hi, >>>>> >>>>> I started using af0a72622a1fb7179cf86ae714d52abadf7d8635 today so I could consume the new fast poll flag, and one of my tests that was previously passing now crashes >>>> Thanks for testing the new stuff! As always, would really appreciate a >>>> test case that I can run, makes my job so much easier. >>> Trigger warning: >>> It's in C++. >> As long as it reproduces, I don't really have to look at it :-) > Instructions: > 1. clone https://github.com/glommer/seastar.git, branch uring-accept-crash > 2. git submodule update --recursive --init, because we have a shit-ton > of submodules because why not. Actually, seastar has only one submodule (dpdk) and it is optional, so you need not clone it. > 3. install all dependencies with ./install-dependencies.sh > note: that does not install liburing yet, you need to have at > least 0.4 (I trust you do), with the patch I just sent to add the fast > poll flag. It still fails sometimes in my system if liburing is > installed in /usr/lib instead of /usr/lib64 because cmake is made by > the devil. > 3. ./configure.py --mode=release --mode dev will compile many times faster > 4. ninja -C build/release tests/unit/unix_domain_test > 5. crash your system (hopefully) by executing > ./build/release/tests/unit/unix_domain_test -- -c1 > --reactor-backend=uring > s/release/dev/ in steps 4, 5 if you use dev mode. >>> I am finishing refactoring some of my code now. It's nothing >>> substantial so I am positive it will hit again. Once I re-reproduce >>> I'll send you instructions. >>> >>> Reading the code it's not obvious to me how it happens, so it'll be >>> harder for me to cook up a simple C reproducer ATM. >> I'll look here as well, as time permits. >> >> >> -- >> Jens Axboe >>