From: Jens Axboe <[email protected]>
To: Hao Xu <[email protected]>, [email protected]
Cc: Pavel Begunkov <[email protected]>
Subject: Re: [PATCH v4 00/11] fixed worker
Date: Tue, 31 May 2022 03:02:51 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 5/31/22 2:55 AM, Hao Xu wrote:
> On 5/31/22 16:46, Jens Axboe wrote:
>> On 5/31/22 1:05 AM, Hao Xu wrote:
>>> On 5/15/22 21:12, Hao Xu wrote:
>>>> From: Hao Xu <[email protected]>
>>>>
>>>> This is the second version of fixed worker implementation.
>>>> Wrote a nop test program to test it, 3 fixed-workers VS 3 normal workers.
>>>> normal workers:
>>>> ./run_nop_wqe.sh nop_wqe_normal 200000 100 3 1-3
>>>> time spent: 10464397 usecs IOPS: 1911242
>>>> time spent: 9610976 usecs IOPS: 2080954
>>>> time spent: 9807361 usecs IOPS: 2039284
>>>>
>>>> fixed workers:
>>>> ./run_nop_wqe.sh nop_wqe_fixed 200000 100 3 1-3
>>>> time spent: 17314274 usecs IOPS: 1155116
>>>> time spent: 17016942 usecs IOPS: 1175299
>>>> time spent: 17908684 usecs IOPS: 1116776
>>>>
>>>> About 2x improvement. From perf result, almost no acct->lock contension.
>>>> Test program: https://github.com/HowHsu/liburing/tree/fixed_worker
>>>> liburing/test/nop_wqe.c
>>>>
>>>> v3->v4:
>>>> - make work in fixed worker's private worfixed worker
>>>> - tweak the io_wqe_acct struct to make it clearer
>>>>
>>>
>>> Hi Jens and Pavel,
>>> Any comments on this series? There are two coding style issue and I'm
>>> going to send v5, before this I'd like to get some comment if there is
>>> any.
>>
>> I'll try to find some time to review it, doing a conference this week.
>
> No worries.
>
>> Rebasing on the current for-5.20/io_uring branch would be a good idea
>> anyway.
>
> I'll do that.
When you do, most/all patches also have:
From: Hao Xu <[email protected]>
From: Hao Xu <[email protected]>
which is a bit confusing, so probably choose one and go with that :-)
--
Jens Axboe
next prev parent reply other threads:[~2022-05-31 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 13:12 [PATCH v4 00/11] fixed worker Hao Xu
2022-05-15 13:12 ` [PATCH 01/11] io-wq: add a worker flag for individual exit Hao Xu
2022-05-15 13:12 ` [PATCH 02/11] io-wq: change argument of create_io_worker() for convienence Hao Xu
2022-05-15 13:12 ` [PATCH 03/11] io-wq: add infra data structure for fixed workers Hao Xu
2022-05-15 13:12 ` [PATCH 04/11] io-wq: tweak io_get_acct() Hao Xu
2022-05-15 13:12 ` [PATCH 05/11] io-wq: fixed worker initialization Hao Xu
2022-05-15 13:12 ` [PATCH 06/11] io-wq: fixed worker exit Hao Xu
2022-05-15 13:12 ` [PATCH 07/11] io-wq: implement fixed worker logic Hao Xu
2022-05-15 13:12 ` [PATCH 08/11] io-wq: batch the handling of fixed worker private works Hao Xu
2022-05-15 13:12 ` [PATCH 09/11] io_uring: add register fixed worker interface Hao Xu
2022-05-15 13:12 ` [PATCH 10/11] io-wq: add an work list for fixed worker Hao Xu
2022-05-15 13:12 ` [PATCH 11/11] io_uring: cancel works in exec " Hao Xu
2022-05-31 7:05 ` [PATCH v4 00/11] " Hao Xu
2022-05-31 8:46 ` Jens Axboe
2022-05-31 8:55 ` Hao Xu
2022-05-31 9:02 ` Jens Axboe [this message]
2022-05-31 9:09 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox