From: Pavel Begunkov <[email protected]>
To: Drew DeVault <[email protected]>, Jens Axboe <[email protected]>,
[email protected]
Cc: noah <[email protected]>
Subject: Re: [PATCH] Add IORING_FEAT_FILES_SKIP feature flag
Date: Thu, 20 May 2021 23:54:27 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CBIEOQ7BRJ0Q.3O3QZBY0ZZPFI@taiga>
On 5/20/21 10:55 PM, Drew DeVault wrote:
> On Thu May 20, 2021 at 9:32 AM EDT, Jens Axboe wrote:
>>> diff --git a/src/include/liburing/io_uring.h b/src/include/liburing/io_uring.h
>>> index 5a3cb90..091dcf7 100644
>>> --- a/src/include/liburing/io_uring.h
>>> +++ b/src/include/liburing/io_uring.h
>>> @@ -285,6 +285,7 @@ struct io_uring_params {
>>> #define IORING_FEAT_SQPOLL_NONFIXED (1U << 7)
>>> #define IORING_FEAT_EXT_ARG (1U << 8)
>>> #define IORING_FEAT_NATIVE_WORKERS (1U << 9)
>>> +#define IORING_FEAT_FILES_SKIP IORING_FEAT_NATIVE_WORKERS
>>
>> I don't think this is a great idea. It can be used as a "probably we
>> have this feature" in userspace, but I don't like aliasing on the
>> kernel side.
>
> This patch is for liburing, following the feedback on the kernel patch
> (which didn't alias, but regardless).
This file is a copy (almost) of the kernel's uapi header, so better be
off this file and have naming that wouldn't alias with names in this
header.
I think that's the problem Jens mean. Jens, is it? And I do still
believe it's a better way to not have an itchy one release gap
between actual feature introduction and new feat flag.
--
Pavel Begunkov
next prev parent reply other threads:[~2021-05-20 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 16:12 [PATCH] Add IORING_FEAT_FILES_SKIP feature flag Drew DeVault
2021-05-20 13:32 ` Jens Axboe
2021-05-20 21:55 ` Drew DeVault
2021-05-20 22:54 ` Pavel Begunkov [this message]
2021-05-20 23:09 ` Drew DeVault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox