From: Donald Hunter <[email protected]>
To: Hao Xu <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH liburing] Fix incorrect close in test for multishot accept
Date: Fri, 17 Jun 2022 11:15:14 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]> (Hao Xu's message of "Fri, 17 Jun 2022 16:28:00 +0800")
Hao Xu <[email protected]> writes:
> Super thanks, Donald. you are right, we skipped the fixed multishot test
> by mistake, the exposed issue after your fix is caused by
> multishot_mask |= (1 << (s_fd[i] - 1))
> which should be
> multishot_mask |= (1U << s_fd[i])
I can confirm this fixes the exposed issue.
> Would you mind me to take this one to my patch series which is to fix
> this and do some cleaning?
Please do.
Thanks,
Donald.
prev parent reply other threads:[~2022-06-17 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 16:22 [PATCH liburing] Fix incorrect close in test for multishot accept Donald Hunter
2022-06-17 8:28 ` Hao Xu
2022-06-17 10:15 ` Donald Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox