From: Stefan Roesch <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected]
Subject: Re: [RFC PATCH v4 2/3] io_uring: add api to set / get napi configuration.
Date: Mon, 21 Nov 2022 10:55:43 -0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Jens Axboe <[email protected]> writes:
> On 11/21/22 10:29 AM, Stefan Roesch wrote:
>> This adds an api to register the busy poll timeout from liburing. To be
>> able to use this functionality, the corresponding liburing patch is needed.
>>
>> Signed-off-by: Stefan Roesch <[email protected]>
>> ---
>> include/linux/io_uring_types.h | 2 +-
>> include/uapi/linux/io_uring.h | 11 +++++++
>> io_uring/io_uring.c | 54 ++++++++++++++++++++++++++++++++++
>> 3 files changed, 66 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/io_uring_types.h b/include/linux/io_uring_types.h
>> index 23993b5d3186..67b861305d97 100644
>> --- a/include/linux/io_uring_types.h
>> +++ b/include/linux/io_uring_types.h
>> @@ -274,8 +274,8 @@ struct io_ring_ctx {
>> struct list_head napi_list; /* track busy poll napi_id */
>> spinlock_t napi_lock; /* napi_list lock */
>>
>> - unsigned int napi_busy_poll_to; /* napi busy poll default timeout */
>> bool napi_prefer_busy_poll;
>> + unsigned int napi_busy_poll_to;
>> #endif
>
> Why is this being moved? Seems unrelated, and it actually creates another
> hole rather than filling one as it did before.
That was not intended. The next version of the patch will restore the
previous order.
next prev parent reply other threads:[~2022-11-21 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 17:29 [RFC PATCH v4 0/3] io_uring: add napi busy polling support Stefan Roesch
2022-11-21 17:29 ` [RFC PATCH v4 1/3] " Stefan Roesch
2022-11-21 17:29 ` [RFC PATCH v4 2/3] io_uring: add api to set / get napi configuration Stefan Roesch
2022-11-21 17:35 ` Jens Axboe
2022-11-21 18:55 ` Stefan Roesch [this message]
2022-11-21 17:37 ` Jens Axboe
2022-11-21 18:55 ` Stefan Roesch
2022-11-21 17:45 ` Ammar Faizi
2022-11-21 18:56 ` Stefan Roesch
2022-11-21 17:29 ` [RFC PATCH v4 3/3] io_uring: add api to set napi prefer busy poll Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox