From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D33C7EE23 for ; Mon, 5 Jun 2023 17:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbjFERqQ (ORCPT ); Mon, 5 Jun 2023 13:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbjFERqQ (ORCPT ); Mon, 5 Jun 2023 13:46:16 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9679D3; Mon, 5 Jun 2023 10:46:14 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 31C145C07D0; Mon, 5 Jun 2023 13:46:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 05 Jun 2023 13:46:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1685987174; x=1686073574; bh=0D eKljtqv6lqaJdIHmqFM3etKOU9LUCfxv5ALEd/s4s=; b=HjUEBHZPVLNdZ8CkrB Jc3kuKIseG7jpdvOLiPhw7qvBppuiVhXr2vnACBmfP/oCIs2mfTPFylcw1bocsBh FyKkONAH+Qv5DWkB8pw2ceNfpd/WDp+2TEq90sIR11p5Cf+ja0cKvHyckJpdliJx LC17HHarEgOR6Fu2WWsPStT2Xr4Daj9bFFljSz84Hug+1c41jsdVtkpI0sgoPgwb v23/ty5h4OuTjVzo/C+qDvcNh7wiOYOyxBRB+X++/hVYtofBTuxKxoE0pJqpPl6+ vvkKupSlR2PUvSMUuhktXSAeOhZRfs9FJZCocidvnReM4U0W5xELkbbnCHRJTpeX lnHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685987174; x=1686073574; bh=0DeKljtqv6lqa JdIHmqFM3etKOU9LUCfxv5ALEd/s4s=; b=xb0FGfJfb+echf8hVRXo3sgzmIYiZ DK23FfWTuh9q9eDdVwzCyyf2IOKLYIKGIFpqy+VIwP7yofyOOFoq6c5gFyV9D46N wAptctg8hDM5610bsIJPfgu241TRZ0B22DY/JoB/XMCqCZSkeoz41RDqTW/UOu1n d+Z4hWmecc6A3ouBTe+H/FrzOgFwvl7Ky4t8aLqS+/cvAfIik+9ZEbn0IELhXCU/ EDU4dTM61pTHLsyh5kGCk5a/Xk7cS3wVwOwDcVPW/aSCYePAjir0MwK8fxYMR/BC /NzRb5XuoGopJjR41gOIOyuiJ4813+mtYw18Xt/hvtmb7BwBRCRa4OG1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelledguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvvefuffgjkfggtgesth dtredttdertdenucfhrhhomhepufhtvghfrghnucftohgvshgthhcuoehshhhrseguvghv khgvrhhnvghlrdhioheqnecuggftrfgrthhtvghrnhepveelgffghfehudeitdehjeevhe dthfetvdfhledutedvgeeikeeggefgudeguedtnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Jun 2023 13:46:12 -0400 (EDT) References: <20230518211751.3492982-1-shr@devkernel.io> <20230518211751.3492982-3-shr@devkernel.io> <20230531102915.0afc570b@kernel.org> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: Jakub Kicinski Cc: io-uring@vger.kernel.org, kernel-team@fb.com, axboe@kernel.dk, ammarfaizi2@gnuweeb.org, netdev@vger.kernel.org, olivier@trillion01.com Subject: Re: [PATCH v13 2/7] net: introduce napi_busy_loop_rcu() Date: Mon, 05 Jun 2023 10:45:55 -0700 In-reply-to: <20230531102915.0afc570b@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Jakub Kicinski writes: > On Thu, 18 May 2023 14:17:46 -0700 Stefan Roesch wrote: >> + * napi_busy_loop_rcu() - busy poll (caller holds rcu read lock) >> + * @napi_id : napi id >> + * @loop_end : function to check for loop end >> + * @loop_end_arg : argument for loop end function >> + * @prefer_busy_poll: prefer busy poll >> + * @budget : budget for busy poll >> + * >> + * Warning: caller must hold rcu read lock. > > I think it's worth noting that until the non-RCU version this one may > exit without calling need_resched(). Otherwise the entire kdoc can go > IMO, it adds no value. It just restates the arguments and the RCU-iness > is obviously implied by the suffix. I fixed the comment.