From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75ECC77B75 for ; Fri, 19 May 2023 23:30:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbjESXac (ORCPT ); Fri, 19 May 2023 19:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjESXab (ORCPT ); Fri, 19 May 2023 19:30:31 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5482EA; Fri, 19 May 2023 16:30:28 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 3324F32009A3; Fri, 19 May 2023 19:30:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 19 May 2023 19:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1684539024; x=1684625424; bh=Sb Mc2wwNhEFGcrl49hIbTYTKfZHyZrwWYHBZy9WFZfQ=; b=rtPvSaOu2mLg9P1nIC dBW+PqHiWHzd7pHhe2NF09nhFbm7b4qIQ+u7ZhsNtvUq3ex6mPULCxN1t+hIXOyV +vThIB31h4HPCcSDSiRK/AzWQXq0lEBCN1VvMQ6Xztb/p/vxLba8wzswwYIQWiuX i2McRVRceVCrs3ng6fxr0obvHAoUVKnTV3Nj3LYR2w3ILw7Ez/uJrGZLYkuIWZXj hPyisyWiHfrP7wumTvfNkEEHJL/AP4a8OdIQY0uFyimNll7GWUN/oW922V5b3i+U ivA0l+rrh1qTA+sZLeaKKlNptyDlXDm68ttGvi3ybHG3GC75Ae3X/AbhZiRbp552 ZfbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684539024; x=1684625424; bh=SbMc2wwNhEFGc rl49hIbTYTKfZHyZrwWYHBZy9WFZfQ=; b=TdMQ1lDAVeNLPWtDBqDO3FaSAUuHM w9qswn9+kAqQnbOoCi35EooMNmrKz2W5UaDAXPyrbVguL3jLN5//rpgzcoqvXGKr qgpW2/AwJ2zdWEWvDyDoXl40aiDIiNNMr5KYqxGS9+l+7IghOpHgBcn55Vvzo/1a DWYF/U278WyheAV6U95/noQV4rxCyesmF4W+GUa5rVpkoTJOiCaj2x5iq2rQAGzU 3eL64iia1FD+FfObSfLG1CqjwaKPYq9IMTNz8223/6tJqg4Ye970L0QKpVsrCdHd +lS7UeaGACxBgSyh+kKNyrfYLdDesRV35/oczc/Q09V4+fjkuQB2NpPFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeiiedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepufhtvghf rghnucftohgvshgthhcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecuggftrfgrth htvghrnhepvdeuieekudefjeejueeifeduuedvvddvjefhkeeivdeghfeivdeffeegffev geeinecuffhomhgrihhnpehgihhthhhusgdrtghomhdpkhgvrhhnvghlrdhorhhgpdhgih hthhhusghushgvrhgtohhnthgvnhhtrdgtohhmnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 19 May 2023 19:30:23 -0400 (EDT) References: <20230518211751.3492982-6-shr@devkernel.io> <202305190745.UK8QQ6fw-lkp@intel.com> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: Jens Axboe Cc: kernel test robot , io-uring@vger.kernel.org, kernel-team@fb.com, oe-kbuild-all@lists.linux.dev, ammarfaizi2@gnuweeb.org, netdev@vger.kernel.org, kuba@kernel.org, olivier@trillion01.com Subject: Re: [PATCH v13 5/7] io-uring: add sqpoll support for napi busy poll Date: Fri, 19 May 2023 16:29:59 -0700 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Jens Axboe writes: > On 5/18/23 6:11?PM, kernel test robot wrote: >> Hi Stefan, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on d2b7fa6174bc4260e496cbf84375c73636914641] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Roesch/net-split-off-__napi_busy_poll-from-napi_busy_poll/20230519-054117 >> base: d2b7fa6174bc4260e496cbf84375c73636914641 >> patch link: https://lore.kernel.org/r/20230518211751.3492982-6-shr%40devkernel.io >> patch subject: [PATCH v13 5/7] io-uring: add sqpoll support for napi busy poll >> config: powerpc-allnoconfig >> compiler: powerpc-linux-gcc (GCC) 12.1.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/intel-lab-lkp/linux/commit/8d324fedc325505406b6ea808d5d7a7cacb321a5 >> git remote add linux-review https://github.com/intel-lab-lkp/linux >> git fetch --no-tags linux-review Stefan-Roesch/net-split-off-__napi_busy_poll-from-napi_busy_poll/20230519-054117 >> git checkout 8d324fedc325505406b6ea808d5d7a7cacb321a5 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202305190745.UK8QQ6fw-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> In file included from io_uring/sqpoll.c:18: >> io_uring/sqpoll.c: In function '__io_sq_thread': >>>> io_uring/napi.h:81:39: error: expected expression before 'do' >> 81 | #define io_napi_sqpoll_busy_poll(ctx) do {} while (0) >> | ^~ >> io_uring/sqpoll.c:198:32: note: in expansion of macro 'io_napi_sqpoll_busy_poll' >> 198 | ret += io_napi_sqpoll_busy_poll(ctx); >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> > > That's my fault, didn't look closely enough. But let's fold this one into > patch 3, to get proper types for !CONFIG_NET_RX_BUSY_POLL. > > > diff --git a/io_uring/napi.h b/io_uring/napi.h > index 69c1970cbecc..64d07317866b 100644 > --- a/io_uring/napi.h > +++ b/io_uring/napi.h > @@ -60,39 +60,43 @@ static inline void io_napi_add(struct io_kiocb *req) > __io_napi_add(ctx, req->file); > } > > -#else > +#else /* CONFIG_NET_RX_BUSY_POLL */ > > static inline void io_napi_init(struct io_ring_ctx *ctx) > { > } > - > static inline void io_napi_free(struct io_ring_ctx *ctx) > { > } > - > static inline int io_register_napi(struct io_ring_ctx *ctx, void __user *arg) > { > return -EOPNOTSUPP; > } > - > static inline int io_unregister_napi(struct io_ring_ctx *ctx, void __user *arg) > { > return -EOPNOTSUPP; > } > - > static inline bool io_napi(struct io_ring_ctx *ctx) > { > return false; > } > - > static inline void io_napi_add(struct io_kiocb *req) > { > } > +static inline void io_napi_adjust_timeout(struct io_ring_ctx *ctx, > + struct io_wait_queue *iowq, > + struct timespec64 *ts) > +{ > +} > +static inline void io_napi_busy_loop(struct io_ring_ctx *ctx, > + struct io_wait_queue *iowq) > +{ > +} > +static inline int io_napi_sqpoll_busy_poll(struct io_ring_ctx *ctx) > +{ > + return 0; > +} > > -#define io_napi_adjust_timeout(ctx, iowq, ts) do {} while (0) > -#define io_napi_busy_loop(ctx, iowq) do {} while (0) > -#define io_napi_sqpoll_busy_poll(ctx) do {} while (0) > - > -#endif > +#endif /* CONFIG_NET_RX_BUSY_POLL */ > > #endif I'll make the above fix in the next version.