From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F029DC433FE for ; Mon, 7 Nov 2022 18:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231580AbiKGSC1 (ORCPT ); Mon, 7 Nov 2022 13:02:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233090AbiKGSBz (ORCPT ); Mon, 7 Nov 2022 13:01:55 -0500 Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99892275F9; Mon, 7 Nov 2022 09:57:52 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 914BC2B06725; Mon, 7 Nov 2022 12:57:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 07 Nov 2022 12:57:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1667843871; x=1667847471; bh=XO0EOt7FUL YlHx772XzPhlZxOfiZ7lFQETl4I1WXvcg=; b=klF4V71LCsFLTLGSfQCO2GhC0w kQIMbHuxgJZeNAK7xyl/7YDpNoneP3xqKBLJYnO66jzScXzMyoxUy/I3l1ACUiiK vNfKYI++fpgUfsXLRBKxo2JCXSL3tiuefbSfpODZjyfQLNnNJyKqQ8GDnyJQj9DG Hj+scXzFwwYGsuDRSWezLl7DK5WXv3pldgU3QQt6JWC6pBOLTMrUhv72RMnNQmT3 RndWTLvl5Xd8Ka8qfgesEQC0h66lim69hRV4R/dm58JWdpvWO2ZvB7+CcCAg/jZc zOb6FjgjMK33sGn/E+barsv0qb5BJQ9q1+HN9LHHLY3G/KgN9QDDg90wBXMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1667843871; x=1667847471; bh=XO0EOt7FULYlHx772XzPhlZxOfiZ 7lFQETl4I1WXvcg=; b=pGRANgAV0DcJOf7vlYTvhFDIlF6AOayveuy+ha/jUeWM IWZ96M2iqMaQ5I9AY0mtLQCr4u0GD6ybY2zWzNAAzWj8A7YMf/UQVfBXcRqNqqLn /JPf3mFnuJsXBXhtZXabDxo7CTCahQLodbrMxpYtK58QaP8M9k/XiMAHH5lrQVXB g9RNCXAXmP3QuDaENlTHfji4d4JVBPVlQlrK0zG7AM0yKBBiKQ5K/eLS0R4AGpbM vKtxEyPKzkgejWlQjPpmSR+Xk/8YUPLK1cRTuk/wodvByRMZIpPM6LXFZawD3hqx YRDMdUHmOG3qsiJeeOWEwBaJQ5PFQgOF//+KJigEoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdekgddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepufhtvghf rghnucftohgvshgthhcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecuggftrfgrth htvghrnhepveelgffghfehudeitdehjeevhedthfetvdfhledutedvgeeikeeggefgudeg uedtnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepsh hhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Nov 2022 12:57:50 -0500 (EST) References: <20221103204017.670757-1-shr@devkernel.io> <20221103204017.670757-4-shr@devkernel.io> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Ammar Faizi Cc: Facebook Kernel Team , Jens Axboe , Olivier Langlois , Jakub Kicinski , netdev Mailing List , io-uring Mailing List Subject: Re: [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll Date: Mon, 07 Nov 2022 09:57:04 -0800 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Ammar Faizi writes: > On 11/4/22 3:40 AM, Stefan Roesch wrote: >> +struct option longopts[] = >> +{ >> + {"address" , 1, NULL, 'a'}, >> + {"busy" , 0, NULL, 'b'}, >> + {"help" , 0, NULL, 'h'}, >> + {"num_pings", 1, NULL, 'n'}, >> + {"port" , 1, NULL, 'p'}, >> + {"sqpoll" , 0, NULL, 's'}, >> + {"timeout" , 1, NULL, 't'}, > > Inconsistent indentation. > Version 2 of the patch fixes this. >> + if (strlen(opt.addr) == 0) { >> + fprintf(stderr, "address option is mandatory\n"); >> + printUsage(argv[0]); >> + exit(-1); >> + } > Don't use integer literal like 0 or -1 as the exit code in tests, use the > exit code protocol: > > T_EXIT_PASS > T_EXIT_FAIL > T_EXIT_SKIP > > They are defined in test/helpers.h. Version 2 of the patch uses the above constants.