From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4FAC4332F for ; Mon, 21 Nov 2022 18:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbiKUS7G (ORCPT ); Mon, 21 Nov 2022 13:59:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230377AbiKUS7D (ORCPT ); Mon, 21 Nov 2022 13:59:03 -0500 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4A7BCFBB1; Mon, 21 Nov 2022 10:59:02 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id C021D2B06846; Mon, 21 Nov 2022 13:59:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 21 Nov 2022 13:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1669057141; x=1669060741; bh=aYKy/dWFpy EcPoInA9iPPi4kQ5Fezf2eiVvaR1Q7RH8=; b=rCqLFx5jHrHDVCUf2MGyaBQMWk yhiTUubU9lJuAsvRKkXhBZn8Yad6tqx2qo81TSvX/0NPSLH6d9eh3JI/NQaGT7TD g21CibRcjdf+e8rcNEfHDYkO1kzkCSSQwfDzQHoGr+3/i98kxLjDhY0TTMc8ZrWK cwX1dgaBr3DrJ55+IH5Ky8+9ITneW3FPO2YfK5fZc3j9J1k+jL7NW6R+XO3BoPON j9g9dzYOhjT1GlLuY3hig/f9a32dpzSrDEltjU0cYWMe7/Ys4EPHD7/lLMg8QV7b r7miNcnh4zUerYcPKHn8+i3/K7XbUSXFomfScO6wWVQoLJpiAoXrk64ZfevA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669057141; x=1669060741; bh=aYKy/dWFpyEcPoInA9iPPi4kQ5Fe zf2eiVvaR1Q7RH8=; b=bJL6sk+Ia6Y8ZUAw+o5TZFar1Q/B+WH/sf8x+6wMPPle L7mHgPsqVIUol8jt28AQypcQE0PU6DDLZyRRDTvE0+DbwB4hUp+aB2AkBLFLP4Mn iMzb1mbdb1yKO6HSROu91P3Zz6cZwA0QAzqV/X5KM7RaaOtGiSWzSEkrXclUhnpG vTOMsyLJJuw9b9jB7tu5fb0qVQsBs3bO+dPoXnQSR5CBMzyM9+u1Eo3BhED93NE9 cbmKES9m9T0LFZopf5/46odvgz2DYSpA2ahw6OcPSPjtqWg7xXtnP2gqIRSnYiOq q4HTGvy8oDJNEY1lybNGSTLq8iQt/6AufQ9iO0T+3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrheeigdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepufhtvghf rghnucftohgvshgthhcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecuggftrfgrth htvghrnhepveelgffghfehudeitdehjeevhedthfetvdfhledutedvgeeikeeggefgudeg uedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh hhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Nov 2022 13:59:00 -0500 (EST) References: <20221119041149.152899-1-shr@devkernel.io> <20221119041149.152899-2-shr@devkernel.io> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Ammar Faizi Cc: Facebook Kernel Team , Jens Axboe , Olivier Langlois , netdev Mailing List , io-uring Mailing List , Jakub Kicinski Subject: Re: [RFC PATCH v4 1/4] liburing: add api to set napi busy poll settings Date: Mon, 21 Nov 2022 10:58:45 -0800 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Ammar Faizi writes: > On 11/19/22 11:11 AM, Stefan Roesch wrote: >> + >> +int io_uring_register_napi(struct io_uring *ring, struct io_uring_napi *napi) >> +{ >> + return __sys_io_uring_register(ring->ring_fd, >> + IORING_REGISTER_NAPI, napi, 0); >> +} >> + >> +int io_uring_unregister_napi(struct io_uring *ring, struct io_uring_napi *napi) >> +{ >> + return __sys_io_uring_register(ring->ring_fd, >> + IORING_REGISTER_NAPI, napi, 0); >> +} > > The latter should be IORING_UNREGISTER_NAPI instead of IORING_REGISTER_NAPI? > Or did I miss something? Thats correct.