From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E665C77B73 for ; Thu, 27 Apr 2023 17:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243521AbjD0Ree (ORCPT ); Thu, 27 Apr 2023 13:34:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244000AbjD0Red (ORCPT ); Thu, 27 Apr 2023 13:34:33 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E7E30EE for ; Thu, 27 Apr 2023 10:34:33 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 774085C015E; Thu, 27 Apr 2023 13:34:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 27 Apr 2023 13:34:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1682616872; x=1682703272; bh=4Q 9v0gmuQl1IuYRxCxa9rQwJ0UIheZAXCuPIF/4EI1Q=; b=DMaUi7fsnXp/lnab6U 1s8J6cB5aU1YRieQeIAlQhh9vBUvj9hDqj/Tjv/TQXZf4cRkyeuj6U7T1OOWD4oq 61bC9XLX8V83G7M4CIvPU3rVTXlmbnoS2/jIVfQuywYqB+UlIggVUYYHt8eR5Fjt Y6dLKbkRdBhx3xUIS42jdukbL1c8zEoRJBahJTLuFWRP/2vP9zljJ2twEZ6slWU4 dkrgYa/luBpVqf+1PrCSJQpoAMA6QzMr7T/OUpsZaRKAMJ5ij2M8oShRLgIm1kmq pd8EwXxvHdygea2+mxF76E06TjkPUPZzPx+q5bAlfJU3bK9qNUscLRBCoNRRhmVk lFcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682616872; x=1682703272; bh=4Q9v0gmuQl1Iu YRxCxa9rQwJ0UIheZAXCuPIF/4EI1Q=; b=HhUvmpfeci98LPOTtNsgz6nmy+V70 MFNb53AvD/lBwzRQadmKBt68UXL7aHtlvnn6wqBcy6J3NmU0dcnWgyY8cFauzCU5 hEHpNGTb8FYwV9PIvTMKSdx9vENkFJUn0Axun54NIbbUiUeg0Caxg9KOQ5n8xpn7 FVupD8tub1g/JJbXHA2/nGoqBJuEdpxEADoEGJeB7bYRDKTdCfMo0KgsY0/GMxVT 1ivnF1ArrHa5ZZwobqQNVSWn3woeJv15KqmjASocf+jQZZcH3bAd0daR/HcMsSOT R/OtMPVK4Lnug6LglcVS1NPiS7YiksitYFGWYK8E2aOWv2IcnhsYYjYaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduiedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdu geeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Apr 2023 13:34:31 -0400 (EDT) References: <20230425181845.2813854-1-shr@devkernel.io> <20230425181845.2813854-3-shr@devkernel.io> <64a48f3b-b231-7b9e-441b-6022693377f3@kernel.dk> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: Jens Axboe Cc: io-uring@vger.kernel.org, kernel-team@fb.com, ammarfaizi2@gnuweeb.org, Olivier Langlois , Jakub Kicinski Subject: Re: [PATCH v10 2/5] io-uring: add napi busy poll support Date: Thu, 27 Apr 2023 10:34:14 -0700 In-reply-to: <64a48f3b-b231-7b9e-441b-6022693377f3@kernel.dk> Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Jens Axboe writes: > On 4/26/23 7:41?PM, Jens Axboe wrote: > > I'd probably also do this: > > > diff --git a/io_uring/napi.c b/io_uring/napi.c > index ca12ff5f5611..35a29fd9afbc 100644 > --- a/io_uring/napi.c > +++ b/io_uring/napi.c > @@ -95,12 +95,17 @@ static bool io_napi_busy_loop_should_end(void *p, unsigned long start_time) > { > struct io_wait_queue *iowq = p; > > - return signal_pending(current) || > - io_should_wake(iowq) || > - io_napi_busy_loop_timeout(start_time, iowq->napi_busy_poll_to); > + if (signal_pending(current)) > + return true; > + if (io_should_wake(iowq)) > + return true; > + if (io_napi_busy_loop_timeout(start_time, iowq->napi_busy_poll_to)) > + return true; > + return false; > } > > as that is easier to read. > Will be changed in the next version.