public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Qingyue Zhang <chunzhennn@qq.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
	Qingyue Zhang <chunzhennn@qq.com>,
	Suoxing Zhang <aftern00n@qq.com>
Subject: [PATCH 2/2] io_uring/kbuf: fix infinite loop in io_kbuf_inc_commit()
Date: Wed, 27 Aug 2025 19:44:53 +0800	[thread overview]
Message-ID: <tencent_000C02641F6250C856D0C26228DE29A3D30A@qq.com> (raw)
In-Reply-To: <20250827114339.367080-1-chunzhennn@qq.com>

In io_kbuf_inc_commit(), buf points to a user-mapped memory region,
which means buf->len might be changed between importing and committing.
Add a check to avoid infinite loop when sum of buf->len is less than
len.

Co-developed-by: Suoxing Zhang <aftern00n@qq.com>
Signed-off-by: Suoxing Zhang <aftern00n@qq.com>
Signed-off-by: Qingyue Zhang <chunzhennn@qq.com>
---
 io_uring/kbuf.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c
index 81a13338dfab..80ffe6755598 100644
--- a/io_uring/kbuf.c
+++ b/io_uring/kbuf.c
@@ -34,11 +34,12 @@ struct io_provide_buf {
 
 static bool io_kbuf_inc_commit(struct io_buffer_list *bl, int len)
 {
+	struct io_uring_buf *buf, *buf_start;
+
+	buf_start = buf = io_ring_head_to_buf(bl->buf_ring, bl->head, bl->mask);
 	while (len) {
-		struct io_uring_buf *buf;
 		u32 this_len;
 
-		buf = io_ring_head_to_buf(bl->buf_ring, bl->head, bl->mask);
 		this_len = min_t(u32, len, buf->len);
 		buf->len -= this_len;
 		if (buf->len) {
@@ -47,6 +48,10 @@ static bool io_kbuf_inc_commit(struct io_buffer_list *bl, int len)
 		}
 		bl->head++;
 		len -= this_len;
+
+		buf = io_ring_head_to_buf(bl->buf_ring, bl->head, bl->mask);
+		if (unlikely(buf == buf_start))
+			break;
 	}
 	return true;
 }
-- 
2.48.1


       reply	other threads:[~2025-08-27 11:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250827114339.367080-1-chunzhennn@qq.com>
2025-08-27 11:44 ` Qingyue Zhang [this message]
2025-08-27 14:30   ` [PATCH 2/2] io_uring/kbuf: fix infinite loop in io_kbuf_inc_commit() Jens Axboe
2025-08-27 21:45     ` Jens Axboe
2025-08-27 21:59       ` Keith Busch
2025-08-27 22:23         ` Jens Axboe
2025-08-28  1:36       ` Qingyue Zhang
2025-08-28  2:08         ` Jens Axboe
2025-08-28  2:49           ` Qingyue Zhang
2025-08-28  2:50             ` Jens Axboe
2025-08-28  2:58               ` Jens Axboe
2025-08-28  3:27                 ` Qingyue Zhang
2025-08-28 11:50                   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_000C02641F6250C856D0C26228DE29A3D30A@qq.com \
    --to=chunzhennn@qq.com \
    --cc=aftern00n@qq.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox