From: Jeff Moyer <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCHSET 0/2] io_uring: handle short reads internally
Date: Thu, 13 Aug 2020 16:25:23 -0400 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]> (Jens Axboe's message of "Thu, 13 Aug 2020 11:56:03 -0600")
Jens Axboe <[email protected]> writes:
> Since we've had a few cases of applications not dealing with this
> appopriately, I believe the safest course of action is to ensure that
> we don't return short reads when we really don't have to.
>
> The first patch is just a prep patch that retains iov_iter state over
> retries, while the second one actually enables just doing retries if
> we get a short read back.
Have you run this through the liburing regression tests?
Tests <eeed8b54e0df-test> <timeout-overflow> <read-write> failed
I'll take a look at the failures, but wanted to bring it to your
attention sooner rather than later. I was using your io_uring-5.9
branch.
-Jeff
next prev parent reply other threads:[~2020-08-13 20:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 17:56 [PATCHSET 0/2] io_uring: handle short reads internally Jens Axboe
2020-08-13 17:56 ` [PATCH 1/2] io_uring: retain iov_iter state over io_read/io_write calls Jens Axboe
2020-08-13 17:56 ` [PATCH 2/2] io_uring: internally retry short reads Jens Axboe
2020-08-13 20:25 ` Jeff Moyer [this message]
2020-08-13 20:33 ` [PATCHSET 0/2] io_uring: handle short reads internally Jens Axboe
2020-08-13 20:37 ` Jens Axboe
2020-08-13 20:41 ` Jens Axboe
2020-08-13 20:49 ` Jeff Moyer
2020-08-13 22:08 ` Jens Axboe
2020-08-13 22:21 ` Jeff Moyer
2020-08-13 22:31 ` Jens Axboe
2020-08-17 20:55 ` Jeff Moyer
2020-08-17 20:57 ` Jens Axboe
2020-08-18 17:55 ` Jeff Moyer
2020-08-18 18:00 ` Jens Axboe
2020-08-18 18:07 ` Jeff Moyer
2020-08-18 18:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox