Re: [liburing patch] test: fix up dead code bugs

[Jeff Moyer <jmoyer@redhat.com>]

Jens Axboe <axboe@kernel.dk> writes:

> On 11/12/19 3:47 PM, Jeff Moyer wrote:
>> Coverity pointed out some dead code.  Fix it.
>> 
>> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>> 
>> diff --git a/test/fsync.c b/test/fsync.c
>> index e6e0898..3c67190 100644
>> --- a/test/fsync.c
>> +++ b/test/fsync.c
>> @@ -96,14 +96,14 @@ static int test_barrier_fsync(struct io_uring *ring)
>>   	io_uring_sqe_set_flags(sqe, IOSQE_IO_DRAIN);
>>   
>>   	ret = io_uring_submit(ring);
>> -	if (ret < 5) {
>> -		printf("Submitted only %d\n", ret);
>> -		goto err;
>> -	} else if (ret < 0) {
>> +	if (ret < 0) {
>>   		printf("sqe submit failed\n");
>>   		if (ret == EINVAL)
>>   			printf("kernel may not support barrier fsync yet\n");
>>   		goto err;
>> +	} else if (ret < 0) {
>> +		printf("Submitted only %d\n", ret);
>> +		goto err;
>>   	}
>
> Looks like you're adding new dead code :-)

Oops!  I'll fix that up.

-Jeff