From: Jeff Moyer <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Bijan Mottahedeh <[email protected]>, [email protected]
Subject: Re: [RFC 2/2] io_uring: mark REQ_NOWAIT for a non-mq queue as unspported
Date: Thu, 28 May 2020 18:12:54 -0400 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]> (Jens Axboe's message of "Thu, 28 May 2020 13:22:19 -0600")
Jens Axboe <[email protected]> writes:
>> poll won't work over dm, so that looks correct. What happens if you edit
>> it and disable poll? Would be curious to see both buffered = 0 and
>> buffered = 1 runs with that.
>>
>> I'll try this here too.
>
> I checked, and with the offending commit reverted, it behaves exactly
> like it should - io_uring doesn't hit endless retries, and we still
> return -EAGAIN to userspace for preadv2(..., RFW_NOWAIT) if not supported.
> I've queued up the revert.
With that revert, I now see an issue with an xfs file system on top of
an nvme device when running the liburing test suite:
Running test 500f9fbadef8-test
Test 500f9fbadef8-test failed with ret 130
That means the test harness timed out, so we never received a
completion.
-Jeff
next prev parent reply other threads:[~2020-05-28 22:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 21:52 [RFC 0/2] io_uring: don't use kiocb.private to store buf_index Bijan Mottahedeh
2020-05-19 21:52 ` [RFC 1/2] " Bijan Mottahedeh
2020-05-19 22:07 ` Jens Axboe
2020-05-19 22:20 ` Jens Axboe
2020-05-19 22:48 ` Bijan Mottahedeh
2020-05-19 21:52 ` [RFC 2/2] io_uring: mark REQ_NOWAIT for a non-mq queue as unspported Bijan Mottahedeh
2020-05-28 18:35 ` Jeff Moyer
2020-05-28 19:01 ` Jens Axboe
2020-05-28 19:22 ` Jens Axboe
2020-05-28 19:31 ` Jeff Moyer
2020-05-28 22:12 ` Jeff Moyer [this message]
2020-05-28 23:03 ` Jens Axboe
2020-05-29 15:02 ` Jeff Moyer
2020-05-29 16:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox