From: Jeff Moyer <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected],
Pavel Begunkov <[email protected]>,
[email protected]
Subject: Re: [PATCH 1/1] io_uring/af_unix: disable sending io_uring over sockets
Date: Fri, 08 Dec 2023 09:59:56 -0500 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]> (Jens Axboe's message of "Thu, 07 Dec 2023 13:33:06 -0700")
Jens Axboe <[email protected]> writes:
> On Wed, 06 Dec 2023 13:26:47 +0000, Pavel Begunkov wrote:
>> File reference cycles have caused lots of problems for io_uring
>> in the past, and it still doesn't work exactly right and races with
>> unix_stream_read_generic(). The safest fix would be to completely
>> disallow sending io_uring files via sockets via SCM_RIGHT, so there
>> are no possible cycles invloving registered files and thus rendering
>> SCM accounting on the io_uring side unnecessary.
>>
>> [...]
>
> Applied, thanks!
So, this will break existing users, right?
-Jeff
next prev parent reply other threads:[~2023-12-08 15:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 13:26 [PATCH 1/1] io_uring/af_unix: disable sending io_uring over sockets Pavel Begunkov
2023-12-06 13:53 ` Pavel Begunkov
2023-12-06 13:55 ` [PATCH RESEND] " Pavel Begunkov
2023-12-07 20:33 ` [PATCH 1/1] " Jens Axboe
2023-12-08 14:59 ` Jeff Moyer [this message]
2023-12-08 15:09 ` Jann Horn
2023-12-08 16:06 ` Jeff Moyer
2023-12-08 16:28 ` Jens Axboe
2023-12-08 17:08 ` Jeff Moyer
2023-12-10 1:23 ` Pavel Begunkov
2023-12-09 1:40 ` [PATCH RESEND] " Jakub Kicinski
2023-12-09 21:30 ` patchwork-bot+netdevbpf
2023-12-10 1:18 ` Pavel Begunkov
2023-12-12 2:39 ` Jakub Kicinski
2023-12-12 4:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox