From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by gnuweeb.org (Postfix) with ESMTPS id EBC3B7E24F for ; Mon, 7 Feb 2022 15:38:25 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=e7TGsDDQ; dkim-atps=neutral Received: by mail-io1-f48.google.com with SMTP id r144so17221370iod.9 for ; Mon, 07 Feb 2022 07:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=uN1CSm5Xp0zfBe9o48GNau7bniWjnN8OKEvpexouZmA=; b=e7TGsDDQnw7DcjI6Brhjc6vCkM0BGnGHOPePjmWKGBU33M8F3SkG5FC9LetY1qxkST uS9Qu7uylVk9F7PIEVKRHenzEBnN8svGYCbBCD/f3btZzar8CHQF71cidCwAJWIniv8E 0lac2EA1iUAVm6024Xlwi3l+/5Ud/MWR2AAd1fOG5Chd1JUbumKrjpzV35Ciq+RSeTGD JvoWrKZqUWs+Mblu+src5E3wJraRRSqr3zQuI2QSYoIy03+wUB8QMHcSXMAmfBLGEkcp xGYWaxbmMw9mlsEcO7NHonfZwk369I36O5lJiHETzzkvNCtGBe2eduQCDw9DZpK9Gv7n ikqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=uN1CSm5Xp0zfBe9o48GNau7bniWjnN8OKEvpexouZmA=; b=32B6eta0x+QH7icwSOat6u8Y7o9xjZteYseTe8ETnzs77OmPQwNLV8+HYRiqT9qbLH mGU+e+xsjZSDtDA4S7G0w0/qdthXutjb1BgJkRCMN3NSPOU+IrNBtQdmssuU9+U9lBBT +F5SDhEBwYLu1655lS0I0IxioxJUgG/3kqc/VQMOUsbck/AFoCN9lBsxr77D9Csd5rxd FOsJj0U+rZc7Zu6GJbJ+N1njK7I29st+C57y/Rh/uLbM/PjcZgY6v/TbAS4hTA7ggywT HlMsoA0ZEBolo3sbuEqO3rNB63LJA4iA0S8wmqS+q7gEJJK5dJjwy1IKbH9WxGH+R1r8 koQQ== X-Gm-Message-State: AOAM532xg9t/BV81eVozPHvtYgFdGoShoO1msP/jC6GFEgDMqgurRkva goT/MfrejF0rvfFeCpBLzStp8U89N0O4kg== X-Google-Smtp-Source: ABdhPJyLp8yQXnthAsAiXf5Lyt8EZbSsYGzPNbpW4fdUvzh6XOdUKIJi5wEmEzcBbdv+ClLxErVLhw== X-Received: by 2002:a05:6602:2c83:: with SMTP id i3mr49969iow.105.1644248305006; Mon, 07 Feb 2022 07:38:25 -0800 (PST) Received: from x1.localdomain ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id z23sm6052912iol.11.2022.02.07.07.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 07:38:24 -0800 (PST) From: Jens Axboe To: Ammar Faizi Cc: "Chen, Rong A" , Linux Kernel Mailing List , Alviro Iskandar Setiawan , io-uring Mailing list , GNU/Weeb Mailing List , Dan Carpenter , Pavel Begunkov , Tea Inside Mailing List , kernel test robot In-Reply-To: <20220207140533.565411-1-ammarfaizi2@gnuweeb.org> References: <20220207114315.555413-1-ammarfaizi2@gnuweeb.org> <91e8ca64-0670-d998-73d8-f75ec5264cb0@kernel.dk> <20220207140533.565411-1-ammarfaizi2@gnuweeb.org> Subject: Re: [PATCH io_uring-5.17 v2] io_uring: Clean up a false-positive warning from GCC 9.3.0 Message-Id: <164424830208.19639.16912208440698766253.b4-ty@kernel.dk> Date: Mon, 07 Feb 2022 08:38:22 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: On Mon, 7 Feb 2022 21:05:33 +0700, Ammar Faizi wrote: > From: Alviro Iskandar Setiawan > > In io_recv(), if import_single_range() fails, the @flags variable is > uninitialized, then it will goto out_free. > > After the goto, the compiler doesn't know that (ret < min_ret) is > always true, so it thinks the "if ((flags & MSG_WAITALL) ..." path > could be taken. > > [...] Applied, thanks! [1/1] io_uring: Clean up a false-positive warning from GCC 9.3.0 commit: 0d7c1153d9291197c1dc473cfaade77acb874b4b Best regards, -- Jens Axboe