From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by gnuweeb.org (Postfix) with ESMTPS id 5A86D7ED7E for ; Fri, 25 Feb 2022 20:29:50 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=sitC+4lc; dkim-atps=neutral Received: by mail-pf1-f180.google.com with SMTP id z15so5650978pfe.7 for ; Fri, 25 Feb 2022 12:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=JWof5HDZQ3ektlA40EL7NC/KrYyJpusnkbk206rsoqA=; b=sitC+4lcfen4ZvSnKe5xfaFJdbELVAwZF+eBN1HRBy+qvChpAHL0mAf0B0QBoBZ5uL NRFOaQW5sU+I11gFo8hIPCKJkYHiv/LkXhNBQac7kyrVsFJEoRLDrpC4CGZvQQQt1mS8 lW+A5IULXAU3fIT/qoZeugKYlWjaLYuI+tD2YLawrg4mwSttzPWNPxMCEk4zdobaj7ra b2wVKQHONJ3Z2pUqhTPClfoLn77vXJj9ZJl9OeUq63fodqDWQpNDdobAUeq/Gat2VcNF z+FlRMnIlrzb5Q6rHVgYOqD6yRr6c5o0ZloJl4K+Y0yX3uEkpzKI3gDxcudkTjaROiPV H3jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=JWof5HDZQ3ektlA40EL7NC/KrYyJpusnkbk206rsoqA=; b=OaHn+0RQidjubYExI9cvnX74rOmU1nLr45UChktKwZYvqVExuc1dS+KQAG23RPmmt1 oSIQW7/yYz1/6d2+GFdHfMawHRF9g9lu5phZZaKFNkdxiMVLsIVUa8+r7KQ+gJg/Lh2e Qo6T9EWbyvPlXZJWpb4Olc5Ab//GgNs1a+VjbNecPnWrDYoH/pkzVrfpBlrN1B1SOw9z 4Np8lYoGKd9dmhoao1bBvYTgkiDMCo83tuOybqwCaSr3K0BynU1DSnGo0phNoe72AGxw CQ8oE/VPyuy918S0XBV+ykP9yhtUtN4CLhG5Kn7BS8GLB4KdYPPYWUBPpDz8R+JP6/ob PSUw== X-Gm-Message-State: AOAM5308kvLBnnFmrGlhP6rNxr9Wlb//i97+zIKzEk6kwoYFyvCNmEds 8dyTIsIeT2PKxWluZic4Qa3fhZzL60lyLQ== X-Google-Smtp-Source: ABdhPJyzLRTNEi0SSNAZALnPgL6FGkZG5uYsDxJBByOoi3HE6vBemBNShffs/CEyi55RVzXCewn3nA== X-Received: by 2002:a05:6a00:23d4:b0:4c9:f1b6:8e97 with SMTP id g20-20020a056a0023d400b004c9f1b68e97mr9191745pfc.27.1645820989591; Fri, 25 Feb 2022 12:29:49 -0800 (PST) Received: from [127.0.1.1] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id b2-20020a056a000a8200b004e1414f0bb1sm4006817pfl.135.2022.02.25.12.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 12:29:49 -0800 (PST) From: Jens Axboe To: Ammar Faizi Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List , Nugra , Tea Inside Mailing List , io-uring Mailing List In-Reply-To: <20220224222427.66206-1-ammarfaizi2@gnuweeb.org> References: <20220224222427.66206-1-ammarfaizi2@gnuweeb.org> Subject: Re: [PATCH liburing v1] src/Makefile: Don't use stack protector for all builds by default Message-Id: <164582098870.3745.10379266162970939889.b4-ty@kernel.dk> Date: Fri, 25 Feb 2022 13:29:48 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: On Fri, 25 Feb 2022 05:24:27 +0700, Ammar Faizi wrote: > Stack protector adds extra mov, extra stack allocation and extra branch > to save and validate the stack canary. While this feature could be > useful to detect stack corruption in some scenarios, it is not really > needed for liburing which is simple enough to review. > > Good code shouldn't corrupt the stack. We don't need this extra > checking at the moment. Just for comparison, let's take a hot function > __io_uring_get_cqe. > > [...] Applied, thanks! [1/1] src/Makefile: Don't use stack protector for all builds by default (no commit info) Best regards, -- Jens Axboe