* [PATCH v1 0/1] Add tailwind configuration
@ 2023-09-26 12:00 Muhammad Rizki
2023-09-26 12:00 ` [PATCH v1 1/1] fix: add *.js and *.css for tailwind config Muhammad Rizki
2023-09-26 12:15 ` [PATCH v1 0/1] Add tailwind configuration Ammar Faizi
0 siblings, 2 replies; 6+ messages in thread
From: Muhammad Rizki @ 2023-09-26 12:00 UTC (permalink / raw)
To: Ammar Faizi
Cc: Muhammad Rizki, Alviro Iskandar Setiawan, Irvan Malik Azantha,
Memet Zx, GNU/Weeb Mailing List
Hai, this is just a small patch for tailwind config:
- Add JS and CSS to the `tailwind.config.js` on content detection.
Please test it first on your device and look for reply UI border color
and user profile name text color, if it's not white then it works,
thanks!
Muhammad Rizki (1):
fix: add *.js and *.css for tailwind config
tailwind.config.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: e4dc93f72a2bb7537a0e67748f3b406c798960a6
--
Muhammad Rizki
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/1] fix: add *.js and *.css for tailwind config
2023-09-26 12:00 [PATCH v1 0/1] Add tailwind configuration Muhammad Rizki
@ 2023-09-26 12:00 ` Muhammad Rizki
2023-09-26 12:15 ` [PATCH v1 0/1] Add tailwind configuration Ammar Faizi
1 sibling, 0 replies; 6+ messages in thread
From: Muhammad Rizki @ 2023-09-26 12:00 UTC (permalink / raw)
To: Ammar Faizi
Cc: Muhammad Rizki, Alviro Iskandar Setiawan, Irvan Malik Azantha,
Memet Zx, GNU/Weeb Mailing List
This config is to detect any possible class names in the JS and CSS
files.
Signed-off-by: Muhammad Rizki <[email protected]>
---
tailwind.config.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tailwind.config.js b/tailwind.config.js
index 39fb13d..56dac06 100644
--- a/tailwind.config.js
+++ b/tailwind.config.js
@@ -1,6 +1,6 @@
/** @type {import('tailwindcss').Config} */
module.exports = {
- content: ["./*.html"],
+ content: ["./*.{html,js,css}"],
theme: {
extend: {},
},
--
Muhammad Rizki
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] Add tailwind configuration
2023-09-26 12:00 [PATCH v1 0/1] Add tailwind configuration Muhammad Rizki
2023-09-26 12:00 ` [PATCH v1 1/1] fix: add *.js and *.css for tailwind config Muhammad Rizki
@ 2023-09-26 12:15 ` Ammar Faizi
2023-09-26 15:55 ` Muhammad Rizki
1 sibling, 1 reply; 6+ messages in thread
From: Ammar Faizi @ 2023-09-26 12:15 UTC (permalink / raw)
To: Muhammad Rizki
Cc: Alviro Iskandar Setiawan, Irvan Malik Azantha, Memet Zx,
GNU/Weeb Mailing List
On Tue, Sep 26, 2023 at 07:00:26PM +0700, Muhammad Rizki wrote:
> Hai, this is just a small patch for tailwind config:
> - Add JS and CSS to the `tailwind.config.js` on content detection.
I don't understand what the problem is. Please explain what goes wrong.
Also, add a "Fixes" tag in the patch, mention the offending commit.
> Please test it first on your device and look for reply UI border color
> and user profile name text color, if it's not white then it works,
> thanks!
Therefore, it doesn't work. After applying your patch and running "npm
run build" plus clear cache, I see white and blue on two different
messages.
This is white:
https://gist.githubusercontent.com/ammarfaizi2/7ba8aa2f542d260ed6863930b3b1b9d4/raw/a53751c4c0eda0455a2b66e8000e520fe8cfd9e1/Screenshot%2520from%25202023-09-26%252019-06-28.png
This is blue:
https://gist.githubusercontent.com/ammarfaizi2/7ba8aa2f542d260ed6863930b3b1b9d4/raw/a53751c4c0eda0455a2b66e8000e520fe8cfd9e1/Screenshot%2520from%25202023-09-26%252019-06-09.png
--
Ammar Faizi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] Add tailwind configuration
2023-09-26 12:15 ` [PATCH v1 0/1] Add tailwind configuration Ammar Faizi
@ 2023-09-26 15:55 ` Muhammad Rizki
2023-09-26 17:04 ` Ammar Faizi
0 siblings, 1 reply; 6+ messages in thread
From: Muhammad Rizki @ 2023-09-26 15:55 UTC (permalink / raw)
To: Ammar Faizi
Cc: Alviro Iskandar Setiawan, Irvan Malik Azantha, Memet Zx,
GNU/Weeb Mailing List
On 26/09/2023 19.15, Ammar Faizi wrote:
> On Tue, Sep 26, 2023 at 07:00:26PM +0700, Muhammad Rizki wrote:
>> Hai, this is just a small patch for tailwind config:
>> - Add JS and CSS to the `tailwind.config.js` on content detection.
>
> I don't understand what the problem is. Please explain what goes wrong.
> Also, add a "Fixes" tag in the patch, mention the offending commit.
It seems Tailwind does not detect class name properly inside inline
JavaScript that contains like `element.classList.add(...,
getColor({first_name}))`, in dev environment, it is working properly in
my device that user profile name and border color are not white colors.
Maybe Irvan knows how to fix it?
>
>> Please test it first on your device and look for reply UI border color
>> and user profile name text color, if it's not white then it works,
>> thanks!
>
> Therefore, it doesn't work. After applying your patch and running "npm
> run build" plus clear cache, I see white and blue on two different
> messages.
>
> This is white:
>
> https://gist.githubusercontent.com/ammarfaizi2/7ba8aa2f542d260ed6863930b3b1b9d4/raw/a53751c4c0eda0455a2b66e8000e520fe8cfd9e1/Screenshot%2520from%25202023-09-26%252019-06-28.png
>
> This is blue:
>
> https://gist.githubusercontent.com/ammarfaizi2/7ba8aa2f542d260ed6863930b3b1b9d4/raw/a53751c4c0eda0455a2b66e8000e520fe8cfd9e1/Screenshot%2520from%25202023-09-26%252019-06-09.png
>
That's weird, I tried the similar commands on Windows:
- npm run build:css
- Get-Content .\index.html | ForEach-Object { $_ -replace 'dist', '.'
} | Set-Content .\dist\index.html
- robocopy static dist\static
- npm run build:minify
Then open the dist index.html file in the browser and it's working properly.
https://i.ibb.co/GdqLj9y/image.png
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] Add tailwind configuration
2023-09-26 15:55 ` Muhammad Rizki
@ 2023-09-26 17:04 ` Ammar Faizi
2023-09-26 17:18 ` Muhammad Rizki
0 siblings, 1 reply; 6+ messages in thread
From: Ammar Faizi @ 2023-09-26 17:04 UTC (permalink / raw)
To: Muhammad Rizki
Cc: Alviro Iskandar Setiawan, Irvan Malik Azantha, Memet Zx,
GNU/Weeb Mailing List
On Tue, Sep 26, 2023 at 10:55:38PM +0700, Muhammad Rizki wrote:
> That's weird, I tried the similar commands on Windows:
> - npm run build:css
> - Get-Content .\index.html | ForEach-Object { $_ -replace 'dist', '.' } |
> Set-Content .\dist\index.html
> - robocopy static dist\static
> - npm run build:minify
>
> Then open the dist index.html file in the browser and it's working properly.
>
> https://i.ibb.co/GdqLj9y/image.png
The prod server will never run Windows. I can't convert those commands
to Linux and don't want to figure out the equivalent commands on Linux.
Specifically the "Get-Content" and "robocopy".
--
Ammar Faizi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] Add tailwind configuration
2023-09-26 17:04 ` Ammar Faizi
@ 2023-09-26 17:18 ` Muhammad Rizki
0 siblings, 0 replies; 6+ messages in thread
From: Muhammad Rizki @ 2023-09-26 17:18 UTC (permalink / raw)
To: Ammar Faizi
Cc: Alviro Iskandar Setiawan, Irvan Malik Azantha, Memet Zx,
GNU/Weeb Mailing List
On 27/09/2023 00.04, Ammar Faizi wrote:
> On Tue, Sep 26, 2023 at 10:55:38PM +0700, Muhammad Rizki wrote:
>> That's weird, I tried the similar commands on Windows:
>> - npm run build:css
>> - Get-Content .\index.html | ForEach-Object { $_ -replace 'dist', '.' } |
>> Set-Content .\dist\index.html
>> - robocopy static dist\static
>> - npm run build:minify
>>
>> Then open the dist index.html file in the browser and it's working properly.
>>
>> https://i.ibb.co/GdqLj9y/image.png
>
> The prod server will never run Windows. I can't convert those commands
> to Linux and don't want to figure out the equivalent commands on Linux.
> Specifically the "Get-Content" and "robocopy".
>
It's actually like npm run build but for Windows only since Windows
doesn't have `cp` and `cat` command:
- `cp` in Windows is `robocopy` or `xcopy`
- `cat` in Windows is `Get-Content` (win pwshell)
The point is, I do exactly like `npm run build` then open it the dist
`index.html` file to the browser on incognito mode and it is working, we
should ask Irvan to try it too.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-26 17:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-26 12:00 [PATCH v1 0/1] Add tailwind configuration Muhammad Rizki
2023-09-26 12:00 ` [PATCH v1 1/1] fix: add *.js and *.css for tailwind config Muhammad Rizki
2023-09-26 12:15 ` [PATCH v1 0/1] Add tailwind configuration Ammar Faizi
2023-09-26 15:55 ` Muhammad Rizki
2023-09-26 17:04 ` Ammar Faizi
2023-09-26 17:18 ` Muhammad Rizki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox