GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
* [PATCH website v2 0/7] Add meta tag and favicon
@ 2022-10-22  8:32 Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 1/7] remove author data and template Memet Zx
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

Hi,
This is v2 revision of additions and fixes:
Previously I added too many image files and they weren't very useful either, 
so I minimized the files that would be used in the repo/website

## Changelog:
v1 -> v2:
- Delete unused images
- refactoring head
- fix known problem

Memet Zx (7):
  remove author data and template
  rename file manifest to nunjucks format
  add favicon images
  add meta tag list file
  add config for favicon
  refactoring head
  add images on data site

 .eleventy.js                        |   3 +--
 _source/_assets/favicon/favicon.ico | Bin 0 -> 1150 bytes
 _source/_data/author.json           |  10 ---------
 _source/_data/site.json             |   1 +
 _source/_includes/head.html         |  13 ++++++-----
 _source/_includes/meta.html         |  33 ++++++++++++++++++++++++++++
 _source/author.njk                  |  10 ---------
 _source/manifest.json               |   0
 _source/manifest.njk                |  19 ++++++++++++++++
 9 files changed, 61 insertions(+), 28 deletions(-)
 create mode 100644 _source/_assets/favicon/favicon.ico
 delete mode 100644 _source/_data/author.json
 create mode 100644 _source/_includes/meta.html
 delete mode 100644 _source/author.njk
 delete mode 100644 _source/manifest.json
 create mode 100644 _source/manifest.njk


base-commit: 657fc07a39da486cf24b3bb4620b554f70de983d
-- 
Memet Zx


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH website v2 1/7] remove author data and template
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 2/7] rename file manifest to nunjucks format Memet Zx
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

i forgot that it wasn't used here

Signed-off-by: Memet Zx <[email protected]>
---
 _source/_data/author.json | 10 ----------
 _source/author.njk        | 10 ----------
 2 files changed, 20 deletions(-)
 delete mode 100644 _source/_data/author.json
 delete mode 100644 _source/author.njk

diff --git a/_source/_data/author.json b/_source/_data/author.json
deleted file mode 100644
index d9abaf5..0000000
--- a/_source/_data/author.json
+++ /dev/null
@@ -1,10 +0,0 @@
-[
-    {
-        "fullname": "Ammar Faizi",
-        "username": "ammarfaizi2"
-    },
-    {
-        "fullname": "irvanmalik48",
-        "username": "irvanmalik48"
-    }
-]
\ No newline at end of file
diff --git a/_source/author.njk b/_source/author.njk
deleted file mode 100644
index 1be8545..0000000
--- a/_source/author.njk
+++ /dev/null
@@ -1,10 +0,0 @@
----
-layout: base
-pagination:
-    data: author
-    size: 1
-    alias: author
-permalink: "author/{{ author.username | slug }}/"
----
-
-{{ author.username }} is {{ author.fullname }}
\ No newline at end of file
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH website v2 2/7] rename file manifest to nunjucks format
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 1/7] remove author data and template Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 3/7] add favicon images Memet Zx
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

when using JSON, the file is not detected and
can't rendered to the public directory
so i reformatted using nunjucks and put the permalink into manifest.json

Signed-off-by: Memet Zx <[email protected]>
---
 _source/manifest.json |  0
 _source/manifest.njk  | 19 +++++++++++++++++++
 2 files changed, 19 insertions(+)
 delete mode 100644 _source/manifest.json
 create mode 100644 _source/manifest.njk

diff --git a/_source/manifest.json b/_source/manifest.json
deleted file mode 100644
index e69de29..0000000
diff --git a/_source/manifest.njk b/_source/manifest.njk
new file mode 100644
index 0000000..f810eee
--- /dev/null
+++ b/_source/manifest.njk
@@ -0,0 +1,19 @@
+---
+permalink: /manifest.json
+---
+{
+  "$schema": "https://json.schemastore.org/web-manifest-combined.json",
+  "name": "{{ site.title }}",
+  "short_name": "{{ site.name }}",
+  "start_url": ".",
+  "display": "standalone",
+  "background_color": "#fff",
+  "description": "{{ site.description }}",
+  "icons": [
+  {
+   "src": "assets/favicon/favicon.ico",
+   "sizes": "16x16",
+   "type": "image\/ico",
+   "density": "0.75"
+  }]
+}
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH website v2 3/7] add favicon images
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 1/7] remove author data and template Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 2/7] rename file manifest to nunjucks format Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 4/7] add meta tag list file Memet Zx
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

the favicon images generated by
https://www.favicon-generator.org/

Signed-off-by: Memet Zx <[email protected]>
---
 _source/_assets/favicon/favicon.ico | Bin 0 -> 1150 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 _source/_assets/favicon/favicon.ico

diff --git a/_source/_assets/favicon/favicon.ico b/_source/_assets/favicon/favicon.ico
new file mode 100644
index 0000000000000000000000000000000000000000..13a010304fc8d2a7a10634dbe9160f8ed63b8487
GIT binary patch
literal 1150
zcmb7^?N8GO5XZY@FXzINtvtv>3vKC-mhw;#c`CF#wMCSt^??eA7(pI=z*(jf2RMeJ
zfNl&Y<H1cH6hW3cg-lU!Fc853BTLwpnQh6of8w)WvUk4QUG6UTy<F~cxjTvEHIco%
zB%+o{DqojKq!NilEs6+<$bYzKBoZ<9Dn*735gj&$&yHfe-#UUu_7y652g<+}LIe8<
z+}TEe-#N6Z+r(%eqSrnmdG|6pVHB;d53O*8aMcjLZ&VTR<_QvFzCok7hFr{viWos7
z45AAiMK8<|5$YjI@DQmP$CxpVA!m$8wFgu3Dk{YX_<2{8Zkl6v<QUo3CCrv3k`nK+
zCvSt~xJ448=7|iQ!R*|ks{0>|#XW=tT_G{-KB2lcf)Y;SDE^tE1HVvI{1f*5&vAGE
zO~d)Wa2@;|lVy_(*B1L*Us8U3i<G(>C{%W_#}YzxRVb2LNwZwVYU`z-dWyo@39`#?
zV5|F@oWpl1YFXf5=Nh?99<0q%q%~Z_KV%m|bSiRPF0zC(#An)x&B#YEWFu9_<EKqQ
zndm@BDI;}%JI3-sV)KUxGfxw{cM63jgYZ~0ZwEx+t8t==%_1bifX?6~I=vX3u?)TO
zFs9to96G;>S?nXXa*iz5IEh6A_{(GPR_l=pNq8%=kwsaEG&nFjPEuO)39gC-a_oaR
ztH0pT@eM5YS<>?#5trscS2%%hNIX7a1_E_iyc29j8C`(c=H^IaFQs+gW2@e#q<)sp
zu35Uf*08<1NrB~8D(vf2xF_*fn~*8>1Sxmnqjr##<EF6kGUe_sscKo_!_IY{e!Io$
z(-nq?mO0Vz1Mi>QU}9v3#Rs<tQY9k~O=hRchOa7Dto=ET+CCaP9&)YkC7wHfaCdB*
zsatD2m|W)Q(M2vc&(m{phU*um@K>dZ^Djdt)F2Bl!&P&ibC;el(ElS{A8paqu}xFc
zZ(P5;&egVAsw*FI^@4|L#~exW7X*f+qY8HttaT8iaZpm*Nqfs920nep!sBh~D_`Jp
zZjzU_&e;?5G@km7_l_;nd~6D*d5K^@H^GWp<bs{rQ@!jdYGGggARoI|s1f%x-~1<e
zSzE+K%wddQVqeBQIjQ$ZkGqRrb`yW^v&c1Ph%waAH!{uTo=Hp@?d-J<Q)nHh+$H82
zo{M++1f}#D+K|UscMp>pJ&GW`jZc7$Olv)vd378=^BIHvcPKs3iy^g#6k{8Xyqg@h
ets(e#;=Q94xpY{(nGw{|eq>(Vy!sFRum3Oi*)ya7

literal 0
HcmV?d00001

-- 
Memet Zx


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH website v2 4/7] add meta tag list file
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
                   ` (2 preceding siblings ...)
  2022-10-22  8:32 ` [PATCH website v2 3/7] add favicon images Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 5/7] add config for favicon Memet Zx
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

useful for SEO and more friendly

Signed-off-by: Memet Zx <[email protected]>
---
 _source/_includes/meta.html | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 _source/_includes/meta.html

diff --git a/_source/_includes/meta.html b/_source/_includes/meta.html
new file mode 100644
index 0000000..59cd048
--- /dev/null
+++ b/_source/_includes/meta.html
@@ -0,0 +1,33 @@
+<meta name="keywords" content="Comunity, GNU/Linux, GNU/Weeb"/>
+<meta name="subject" content="{{ site.description }}">
+<meta name="copyright"content="{{ site.name }}">
+<meta name="language" content="English">
+<meta name="robots" content="index,follow" />
+<meta name="revised" content="" />
+<meta name="abstract" content="">
+<meta name="topic" content="">
+<meta name="summary" content="{{ site.description }}">
+<meta name="Classification" content="Comunity">
+<meta name="author" content="gnuweeb, [email protected]">
+<meta name="copyright" content="">
+<meta name="reply-to" content="[email protected]">
+<meta name="owner" content="ammarfaizi2">
+<meta name="url" content="{{ site.url }}">
+<meta name="identifier-URL" content="{{ site.url }}">
+<meta name="category" content="Tech, GNU/Linux">
+<meta name="coverage" content="Worldwide">
+<meta name="distribution" content="Global">
+<meta name="rating" content="General">
+<meta name="revisit-after" content="7 days">
+<meta http-equiv="Expires" content="0">
+<meta http-equiv="Pragma" content="no-cache">
+<meta http-equiv="Cache-Control" content="no-cache">
+
+<meta name="og:title" content="{{ site.title }}{% if section_title %} {{ section_title }}{% endif %}{% if title %}: {{ title }}{% endif %}"/>
+<meta name="og:type" content="{{ site.description }}"/>
+<meta name="og:url" content="{{ site.url }}"/>
+<meta name="og:image" content="{{ site.images }}"/>
+<meta name="og:site_name" content="{{ site.title }}"/>
+<meta name="og:description" content="{{ site.description }}"/>
+<meta name="fb:page_id" content="" />
+<meta name="og:email" content="[email protected]"/>
\ No newline at end of file
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH website v2 5/7] add config for favicon
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
                   ` (3 preceding siblings ...)
  2022-10-22  8:32 ` [PATCH website v2 4/7] add meta tag list file Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 6/7] refactoring head Memet Zx
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

add favicon pass trough copy when rendering

Signed-off-by: Memet Zx <[email protected]>
---
 .eleventy.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.eleventy.js b/.eleventy.js
index 2e8473a..d47b932 100644
--- a/.eleventy.js
+++ b/.eleventy.js
@@ -113,8 +113,7 @@ module.exports = function(eleventyConfig) {
   -------------------------------------------------------------------------- */
   eleventyConfig.setLibrary('md', markdownLib);
   eleventyConfig.setDataDeepMerge(true);
-  eleventyConfig.addPassthroughCopy({ '_source/_assets/fonts': 'assets/fonts' });
-  eleventyConfig.addPassthroughCopy({ '_source/_assets/images': 'assets' });
+  eleventyConfig.addPassthroughCopy({ '_source/_assets/favicon': 'assets/favicon' });
 
   return {
     dir: {
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH website v2 6/7] refactoring head
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
                   ` (4 preceding siblings ...)
  2022-10-22  8:32 ` [PATCH website v2 5/7] add config for favicon Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:32 ` [PATCH website v2 7/7] add images on data site Memet Zx
  2022-10-22  8:55 ` [PATCH website v2 0/7] Add meta tag and favicon Ammar Faizi
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

add manifest, favicon images and include meta tags file

Signed-off-by: Memet Zx <[email protected]>
---
 _source/_includes/head.html | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/_source/_includes/head.html b/_source/_includes/head.html
index a391c18..5dd506f 100644
--- a/_source/_includes/head.html
+++ b/_source/_includes/head.html
@@ -5,14 +5,15 @@
   <title>{{ site.title }}{% if section_title %} {{ section_title }}{% endif %}{% if title %}: {{ title }}{% endif %}</title>
   {% if description -%}
     <meta name="description" content="{{ description }}">
+    {% else %}
+    <meta name="description" content="{{ site.description }}">
   {% endif -%}
   <link rel="canonical" href="{{ page.url | remove: "index.html" | remove: ".html" | prepend: site.url }}">
-
-<!--   <link rel="alternate icon" type="image/png" sizes="32x32" href="/assets/favicon-32x32.png">
-  <link rel="icon" type="image/svg+xml" href="/assets/favicon.svg">
-  <link rel="mask-icon" href="/assets/favicon.svg" color="#000000">
-  <link rel="apple-touch-icon" href="/assets/favicon-196x196.png"> -->
-
+  {% include 'meta.html' %}
+  <link rel="shortcut icon" href="/assets/favicon/favicon.ico">
+  <meta name="msapplication-TileColor" content="#ffffff">
+  <meta name="theme-color" content="#ffffff">
+  <link rel="manifest" href="manifest.json" />
   <link rel="stylesheet" href="/assets/main.css">
   <script src="/assets/main.js" type="module"></script>
 </head>
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH website v2 7/7] add images on data site
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
                   ` (5 preceding siblings ...)
  2022-10-22  8:32 ` [PATCH website v2 6/7] refactoring head Memet Zx
@ 2022-10-22  8:32 ` Memet Zx
  2022-10-22  8:55 ` [PATCH website v2 0/7] Add meta tag and favicon Ammar Faizi
  7 siblings, 0 replies; 9+ messages in thread
From: Memet Zx @ 2022-10-22  8:32 UTC (permalink / raw)
  To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

From: Memet Zx <[email protected]>

called on meta tag file

Signed-off-by: Memet Zx <[email protected]>
---
 _source/_data/site.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/_source/_data/site.json b/_source/_data/site.json
index f9cebc6..93073f9 100644
--- a/_source/_data/site.json
+++ b/_source/_data/site.json
@@ -3,6 +3,7 @@
     "name": "GNU/Weeb",
     "description": "We are working to build community through open source technology..",
     "url": "https://www.gnuweeb.org",
+    "images": "https://avatars.githubusercontent.com/u/81083695?v=4",
     "language": "en",
     "resource": [
         {
-- 
Memet Zx


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH website v2 0/7] Add meta tag and favicon
  2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
                   ` (6 preceding siblings ...)
  2022-10-22  8:32 ` [PATCH website v2 7/7] add images on data site Memet Zx
@ 2022-10-22  8:55 ` Ammar Faizi
  7 siblings, 0 replies; 9+ messages in thread
From: Ammar Faizi @ 2022-10-22  8:55 UTC (permalink / raw)
  To: Memet Zx, GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx

On Sat, 22 Oct 2022 15:32:40 +0700, Memet Zx wrote:
> From: Memet Zx <[email protected]>
> 
> Hi,
> This is v2 revision of additions and fixes:
> Previously I added too many image files and they weren't very useful either,
> so I minimized the files that would be used in the repo/website
> 
> [...]

Applied, with extra wordsmith. Please put a reason in each commit
message next time. I don't have much to say as I'm not a frontend
guy.

You can fast-foward pull these changes from:

   https://github.com/GNUWeeb/website.git zxce3

Thanks!

[1/7] remove author data and template
      commit: d41b935e3d1d9d7f5f2a83e8e2c7255f95d2e38c
[2/7] rename file manifest to nunjucks format
      commit: 8c75172d0c25c982014ffb13bd9c6f1d366cda52
[3/7] add favicon images
      commit: 5d2f0b64d6f9c62875cb92473ea43cc8fa07acf9
[4/7] add meta tag list file
      commit: 233d0b894be2f278db3989beb00d11baaa10ea19
[5/7] add config for favicon
      commit: e1d09f488f8bf34d9197bd222624d87878e52aee
[6/7] refactoring head
      commit: fc33699272d118354d14e8dc5736243a537a55c8
[7/7] add images on data site
      commit: 06e5149fe9cd03b1e545f2382d085fc0b72b1194

Best regards,
-- 
Ammar Faizi

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-10-22  8:55 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-22  8:32 [PATCH website v2 0/7] Add meta tag and favicon Memet Zx
2022-10-22  8:32 ` [PATCH website v2 1/7] remove author data and template Memet Zx
2022-10-22  8:32 ` [PATCH website v2 2/7] rename file manifest to nunjucks format Memet Zx
2022-10-22  8:32 ` [PATCH website v2 3/7] add favicon images Memet Zx
2022-10-22  8:32 ` [PATCH website v2 4/7] add meta tag list file Memet Zx
2022-10-22  8:32 ` [PATCH website v2 5/7] add config for favicon Memet Zx
2022-10-22  8:32 ` [PATCH website v2 6/7] refactoring head Memet Zx
2022-10-22  8:32 ` [PATCH website v2 7/7] add images on data site Memet Zx
2022-10-22  8:55 ` [PATCH website v2 0/7] Add meta tag and favicon Ammar Faizi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox