* [PATCH liburing v1] liburing.map: Export `io_uring_{enable_rings,register_restrictions}`
@ 2023-01-14 3:54 Ammar Faizi
2023-01-14 3:57 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Ammar Faizi @ 2023-01-14 3:54 UTC (permalink / raw)
To: Jens Axboe
Cc: Ammar Faizi, Pavel Begunkov, Gilang Fachrezy,
io-uring Mailing List, VNLX Kernel Department,
GNU/Weeb Mailing List, Dylan Yudaken, Stefano Garzarella
From: Ammar Faizi <[email protected]>
When adding these two functions, Stefano didn't add
io_uring_enable_rings() and io_uring_register_restrictions() to
liburing.map. It causes a linking problem. Add them to liburing.map.
This issue hits liburing 2.0 to 2.3.
Closes: https://github.com/axboe/liburing/pull/774
Fixes: https://github.com/axboe/liburing/issues/773
Fixes: https://github.com/facebook/folly/issues/1908
Fixes: d2654b1ac886 ("Add helper to enable rings")
Fixes: 25cf9b968a27 ("Add helper to register restrictions")
Cc: Dylan Yudaken <[email protected]>
Cc: Stefano Garzarella <[email protected]>
Signed-off-by: Ammar Faizi <[email protected]>
---
src/liburing.map | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/liburing.map b/src/liburing.map
index 67aebae..1dbe765 100644
--- a/src/liburing.map
+++ b/src/liburing.map
@@ -73,4 +73,7 @@ LIBURING_2.4 {
io_uring_major_version;
io_uring_minor_version;
io_uring_check_version;
+
+ io_uring_enable_rings;
+ io_uring_register_restrictions;
} LIBURING_2.3;
base-commit: 0df8a379e929641699c2ab1f42de1efd2515b908
--
Ammar Faizi
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH liburing v1] liburing.map: Export `io_uring_{enable_rings,register_restrictions}`
2023-01-14 3:54 [PATCH liburing v1] liburing.map: Export `io_uring_{enable_rings,register_restrictions}` Ammar Faizi
@ 2023-01-14 3:57 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2023-01-14 3:57 UTC (permalink / raw)
To: Ammar Faizi
Cc: Pavel Begunkov, Gilang Fachrezy, io-uring Mailing List,
VNLX Kernel Department, GNU/Weeb Mailing List, Dylan Yudaken,
Stefano Garzarella
On Sat, 14 Jan 2023 10:54:05 +0700, Ammar Faizi wrote:
> When adding these two functions, Stefano didn't add
> io_uring_enable_rings() and io_uring_register_restrictions() to
> liburing.map. It causes a linking problem. Add them to liburing.map.
>
> This issue hits liburing 2.0 to 2.3.
>
>
> [...]
Applied, thanks!
[1/1] liburing.map: Export `io_uring_{enable_rings,register_restrictions}`
commit: 19424b0baa5999918701e1972b901b0937331581
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-14 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-14 3:54 [PATCH liburing v1] liburing.map: Export `io_uring_{enable_rings,register_restrictions}` Ammar Faizi
2023-01-14 3:57 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox