From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Dylan Yudaken <[email protected]>,
Ammar Faizi <[email protected]>,
Pavel Begunkov <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
io-uring Mailing List <[email protected]>,
Facebook Kernel Team <[email protected]>
Subject: [PATCH liburing v2 0/3] Clean up clang `-Wshorten-64-to-32` warnings
Date: Thu, 20 Oct 2022 20:14:52 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
From: Ammar Faizi <[email protected]>
Hi Jens,
This is a v2.
v2:
- Fix Signed-off-by tag.
- Make the cast in patch #1 consistent.
Please consider this small cleanup series before the release.
This series is a follow up of the clean up `-Wshorten-64-to-32`
warnings that I discussed with Dylan previously. It only addresses
the warnings in the src/ dir (main library). We ignore the tests
for now.
`-Wshorten-64-to-32` is a clang-specific flag, it currently doesn't
exist in GCC.
There are 3 patches in this series:
- Patch 1 is to clean up the warnings in the main library
(this is based on a patch from Dylan).
Taken from: https://github.com/DylanZA/liburing/commit/cdd6dfbb9019.patch
- Patch 2 is to introduce LIBURING_CFLAGS variable in the Makefile. We
need this varaible to apply specific compiler flags to the main
library only. Currently, this flag is only used by the GitHub bot.
- Patch 3 is to integrate `-Wshorten-64-to-32` flag to the GitHub bot.
Signed-off-by: Ammar Faizi <[email protected]>
---
Ammar Faizi (2):
Makefile: Introduce `LIBURING_CFLAGS` variable
github: Append `-Wshorten-64-to-32` flag for clang build
Dylan Yudaken (1):
liburing: Clean up `-Wshorten-64-to-32` warnings from clang
.github/workflows/build.yml | 4 ++++
src/Makefile | 5 ++++-
src/arch/syscall-defs.h | 4 ++--
src/register.c | 5 ++++-
src/setup.c | 12 ++++++------
src/syscall.h | 4 ++--
6 files changed, 22 insertions(+), 12 deletions(-)
base-commit: 3049530665ba6464f3c5f6f80b28e965719ca602
--
Ammar Faizi
next reply other threads:[~2022-10-20 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 13:14 Ammar Faizi [this message]
2022-10-20 13:14 ` [PATCH liburing v2 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Ammar Faizi
2022-10-20 13:14 ` [PATCH liburing v2 2/3] Makefile: Introduce `LIBURING_CFLAGS` variable Ammar Faizi
2022-10-20 13:14 ` [PATCH liburing v2 3/3] github: Append `-Wshorten-64-to-32` flag for clang build Ammar Faizi
2022-10-20 14:11 ` [PATCH liburing v2 0/3] Clean up clang `-Wshorten-64-to-32` warnings Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox