From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Dylan Yudaken <[email protected]>,
Ammar Faizi <[email protected]>,
Pavel Begunkov <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
io-uring Mailing List <[email protected]>,
Facebook Kernel Team <[email protected]>
Subject: [PATCH liburing v2 3/3] github: Append `-Wshorten-64-to-32` flag for clang build
Date: Thu, 20 Oct 2022 20:14:55 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
From: Ammar Faizi <[email protected]>
liburing has a couple of int shortening issues found by clang. A
previous commit has cleaned them up. Integrate -Wshorten-64-to-32
flag to the GitHub bot to spot the same issue in the future.
This flag is clang-specific, it currently doesn't exist in GCC.
Signed-off-by: Ammar Faizi <[email protected]>
---
.github/workflows/build.yml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2608644..b0e669d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -26,6 +26,7 @@ jobs:
cxx_pkg: clang
cc: clang
cxx: clang++
+ extra_flags: -Wshorten-64-to-32
# x86 (32-bit) gcc
- arch: i686
@@ -86,6 +87,9 @@ jobs:
env:
FLAGS: -g -O3 -Wall -Wextra -Werror
+ # Flags for building sources in src/ dir only.
+ LIBURING_CFLAGS: ${{matrix.extra_flags}}
+
steps:
- name: Checkout source
uses: actions/checkout@v2
--
Ammar Faizi
next prev parent reply other threads:[~2022-10-20 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 13:14 [PATCH liburing v2 0/3] Clean up clang `-Wshorten-64-to-32` warnings Ammar Faizi
2022-10-20 13:14 ` [PATCH liburing v2 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Ammar Faizi
2022-10-20 13:14 ` [PATCH liburing v2 2/3] Makefile: Introduce `LIBURING_CFLAGS` variable Ammar Faizi
2022-10-20 13:14 ` Ammar Faizi [this message]
2022-10-20 14:11 ` [PATCH liburing v2 0/3] Clean up clang `-Wshorten-64-to-32` warnings Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox