* [PATCH gwspamd 1/2] gwspamd: web: Add *.patch and *.diff to .gitignore
@ 2023-04-19 11:58 Memet Zx
2023-04-19 11:58 ` [PATCH gwspamd 2/2] gwspamd: web: Improving accessibility in select image section Memet Zx
0 siblings, 1 reply; 3+ messages in thread
From: Memet Zx @ 2023-04-19 11:58 UTC (permalink / raw)
To: Ammar Faizi; +Cc: Memet Zx, GNU/Weeb Mailing List, Memet Zx
Avoid patch and diff file being committed.
Signed-off-by: Memet Zx <[email protected]>
---
web/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/web/.gitignore b/web/.gitignore
index 233aef8..6531cf5 100644
--- a/web/.gitignore
+++ b/web/.gitignore
@@ -1,2 +1,4 @@
/config.php
/gwspamd.sql.gz
+*.patch
+*.diff
base-commit: dbb57d61ed9e417582c571af92d364c3889afaf7
--
Memet Zx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH gwspamd 2/2] gwspamd: web: Improving accessibility in select image section
2023-04-19 11:58 [PATCH gwspamd 1/2] gwspamd: web: Add *.patch and *.diff to .gitignore Memet Zx
@ 2023-04-19 11:58 ` Memet Zx
2023-04-19 17:27 ` Ammar Faizi
0 siblings, 1 reply; 3+ messages in thread
From: Memet Zx @ 2023-04-19 11:58 UTC (permalink / raw)
To: Ammar Faizi; +Cc: Memet Zx, GNU/Weeb Mailing List, Memet Zx
Replacing the plain input file element with a custom-file wrapper
element that includes a label for better accessibility.
The label text is "Choose images".
Signed-off-by: Memet Zx <[email protected]>
---
web/views/components/modal.php | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/web/views/components/modal.php b/web/views/components/modal.php
index 08e86b9..40fa470 100644
--- a/web/views/components/modal.php
+++ b/web/views/components/modal.php
@@ -24,7 +24,10 @@
<h5 class="modal-title">Update Images</h5>
<canvas style="touch-action: none; cursor: move;" id="photo_canvas"></canvas>
<input type="range" min="1" max="5" value="1" step="0.01" id="photo_range" style="display: none;" />
- <input type="file" id="photo" name="photo" accept=".jpg,.png,.gif,.jpeg" />
+ <div class="custom-file">
+ <input type="file" id="photo" name="photo" accept=".jpg,.png,.gif,.jpeg">
+ <label for="photo">Choose images</label>
+ </div>
<div class="text-right mt-20">
<button type="button" onclick="apply_photo();" data-dismiss="modal" class="btn">Apply photo</button>
<button class="btn" data-dismiss="modal">Close</button>
--
Memet Zx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH gwspamd 2/2] gwspamd: web: Improving accessibility in select image section
2023-04-19 11:58 ` [PATCH gwspamd 2/2] gwspamd: web: Improving accessibility in select image section Memet Zx
@ 2023-04-19 17:27 ` Ammar Faizi
0 siblings, 0 replies; 3+ messages in thread
From: Ammar Faizi @ 2023-04-19 17:27 UTC (permalink / raw)
To: Memet Zx; +Cc: GNU/Weeb Mailing List, Memet Zx
On 4/19/23 6:58 PM, Memet Zx wrote:
> Replacing the plain input file element with a custom-file wrapper
> element that includes a label for better accessibility.
> The label text is "Choose images".
I don't think this patch makes sense. You can only have one photo
profile at a time. So the noun has to be singular: "image".
--
Ammar Faizi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-19 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 11:58 [PATCH gwspamd 1/2] gwspamd: web: Add *.patch and *.diff to .gitignore Memet Zx
2023-04-19 11:58 ` [PATCH gwspamd 2/2] gwspamd: web: Improving accessibility in select image section Memet Zx
2023-04-19 17:27 ` Ammar Faizi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox