* [PATCH Website v1 0/2] Improve website accessibility
@ 2023-01-29 1:14 Memet Zx
2023-01-29 1:14 ` [PATCH Website v1 1/2] style.css: fixed background and foreground colors Memet Zx
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Memet Zx @ 2023-01-29 1:14 UTC (permalink / raw)
To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx
From: Memet Zx <[email protected]>
Hello,
here I want to improve the accessibility of the website starting with
a text color that has less contrast and `<html>` elements
that don't have the `[lang]` attribute.
Link: https://pagespeed.web.dev/report?url=https://www.gnuweeb.org
Memet Zx (2):
style.css: fixed background and foreground colors
body.php: Adding the `[lang]` attribute to the `<html>` element
public/assets/css/style.css | 20 ++++++++++----------
src/components/body.php | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
base-commit: c2ab92882f579de19b6e8cd5365e06d6a2a24bbc
--
Memet Zx
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH Website v1 1/2] style.css: fixed background and foreground colors 2023-01-29 1:14 [PATCH Website v1 0/2] Improve website accessibility Memet Zx @ 2023-01-29 1:14 ` Memet Zx 2023-01-29 1:14 ` [PATCH Website v1 2/2] body.php: Adding the `[lang]` attribute to the `<html>` element Memet Zx 2023-01-29 11:19 ` [PATCH Website v1 0/2] Improve website accessibility Ammar Faizi 2 siblings, 0 replies; 8+ messages in thread From: Memet Zx @ 2023-01-29 1:14 UTC (permalink / raw) To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx From: Memet Zx <[email protected]> Text that has low contrast is difficult or unreadable for most users Signed-off-by: Memet Zx <[email protected]> --- public/assets/css/style.css | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/public/assets/css/style.css b/public/assets/css/style.css index b5e86cb..060e58c 100644 --- a/public/assets/css/style.css +++ b/public/assets/css/style.css @@ -10,7 +10,7 @@ body { font-family: oxygen, sans-serif; background: #F0EDE3; - color: #33290A; + color: #000; } #wrapper { @@ -56,7 +56,7 @@ body { } #banner li>a { - color: #B39223; + color: #795E01; white-space: nowrap; font-size: 90%; } @@ -116,12 +116,12 @@ a:visited { } a:hover { - color: #B39223; + color: #795E01; text-decoration: none; } a:active { - color: #B39223; + color: #795E01; text-decoration: none; } @@ -150,7 +150,7 @@ hr { #latest { float: right; background: #FFD133; - box-shadow: -0.1em -0.3em 0.5em #B39223 inset; + box-shadow: -0.1em -0.3em 0.5em #795E01 inset; color: #4C3D00; border-radius: 0.5em; margin: 1em 2.2em 4em 0; @@ -208,7 +208,7 @@ hr { float: right; text-align: center; background: #F0EDE3; - color: #827A5E; + color: #3E3000; border: thin solid #CCC8B8; box-shadow: 0 0.1em 0.2em #CCC8B8 inset; border-radius: 0.5em; @@ -312,12 +312,12 @@ pre>code { } article h1 { - color: #33290A; + color: #000; margin: 0 0 0.9em 0; } article h1>a { - color: #33290A !important; + color: #000 !important; transition: none; } @@ -410,7 +410,7 @@ a.readmore:active { #contentinfo { clear: both; text-align: center; - color: #827A5E; + color: #3E3000; margin: 2em auto; padding-top: 0.5em; } @@ -450,4 +450,4 @@ th { td { border: 1px solid; padding: 5px; -} \ No newline at end of file +} -- Memet Zx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH Website v1 2/2] body.php: Adding the `[lang]` attribute to the `<html>` element 2023-01-29 1:14 [PATCH Website v1 0/2] Improve website accessibility Memet Zx 2023-01-29 1:14 ` [PATCH Website v1 1/2] style.css: fixed background and foreground colors Memet Zx @ 2023-01-29 1:14 ` Memet Zx 2023-01-29 11:19 ` [PATCH Website v1 0/2] Improve website accessibility Ammar Faizi 2 siblings, 0 replies; 8+ messages in thread From: Memet Zx @ 2023-01-29 1:14 UTC (permalink / raw) To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx From: Memet Zx <[email protected]> If the page does not specify a language attribute, the screen reader assumes that the page is in the default language that the user selected when setting up the screen reader. this will be a problem for some people and will have difficulty pronouncing the text on the page correctly. Signed-off-by: Memet Zx <[email protected]> --- src/components/body.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/body.php b/src/components/body.php index d72ce39..8cd450b 100644 --- a/src/components/body.php +++ b/src/components/body.php @@ -1,5 +1,5 @@ <!DOCTYPE html> -<html> +<html lang="en"> <?php require __DIR__."/head.php"; ?> <body id="index" class="home"> <div id="wrapper"> -- Memet Zx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH Website v1 0/2] Improve website accessibility 2023-01-29 1:14 [PATCH Website v1 0/2] Improve website accessibility Memet Zx 2023-01-29 1:14 ` [PATCH Website v1 1/2] style.css: fixed background and foreground colors Memet Zx 2023-01-29 1:14 ` [PATCH Website v1 2/2] body.php: Adding the `[lang]` attribute to the `<html>` element Memet Zx @ 2023-01-29 11:19 ` Ammar Faizi 2023-01-29 11:47 ` [PATCH Website v2 0/2] Fix commit messages Memet Zx 2 siblings, 1 reply; 8+ messages in thread From: Ammar Faizi @ 2023-01-29 11:19 UTC (permalink / raw) To: Memet Zx; +Cc: GNU/Weeb Mailing List, Irvan Malik, Memet Zx On Sun, Jan 29, 2023 at 8:14 AM Memet Zx <[email protected]> wrote: > Memet Zx (2): > style.css: fixed background and foreground colors s/fixed/fix/ > body.php: Adding the `[lang]` attribute to the `<html>` element s/Adding/Add/ -- Ammar Faizi ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH Website v2 0/2] Fix commit messages 2023-01-29 11:19 ` [PATCH Website v1 0/2] Improve website accessibility Ammar Faizi @ 2023-01-29 11:47 ` Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 1/2] style.css: Fix background and foreground colors Memet Zx ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Memet Zx @ 2023-01-29 11:47 UTC (permalink / raw) To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx From: Memet Zx <[email protected]> hello again, This series contains fixes to the commit message: # Patch 1 > --- style.css: fixed background and foreground colors > +++ style.css: Fix background and foreground colors # Patch 2 > --- body.php: Adding the `[lang]` attribute to the `<html>` element > +++ body.php: Add the `[lang]` attribute to the `<html>` element Link: https://lore.gnuweeb.org/gwml/CAFBCWQKp21mWksKW_yna-KvNrsfiqxfoNQpjJCpkx=4A2F-OFw@mail.gmail.com/ Memet Zx (2): style.css: Fix background and foreground colors body.php: Add the `[lang]` attribute to the `<html>` element public/assets/css/style.css | 20 ++++++++++---------- src/components/body.php | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) base-commit: c2ab92882f579de19b6e8cd5365e06d6a2a24bbc -- Memet Zx ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH Website v2 1/2] style.css: Fix background and foreground colors 2023-01-29 11:47 ` [PATCH Website v2 0/2] Fix commit messages Memet Zx @ 2023-01-29 11:47 ` Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 2/2] body.php: Add the `[lang]` attribute to the `<html>` element Memet Zx 2023-01-29 11:51 ` [PATCH Website v2 0/2] Fix commit messages Ammar Faizi 2 siblings, 0 replies; 8+ messages in thread From: Memet Zx @ 2023-01-29 11:47 UTC (permalink / raw) To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx From: Memet Zx <[email protected]> Text that has low contrast is difficult or unreadable for most users Signed-off-by: Memet Zx <[email protected]> --- public/assets/css/style.css | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/public/assets/css/style.css b/public/assets/css/style.css index b5e86cb..060e58c 100644 --- a/public/assets/css/style.css +++ b/public/assets/css/style.css @@ -10,7 +10,7 @@ body { font-family: oxygen, sans-serif; background: #F0EDE3; - color: #33290A; + color: #000; } #wrapper { @@ -56,7 +56,7 @@ body { } #banner li>a { - color: #B39223; + color: #795E01; white-space: nowrap; font-size: 90%; } @@ -116,12 +116,12 @@ a:visited { } a:hover { - color: #B39223; + color: #795E01; text-decoration: none; } a:active { - color: #B39223; + color: #795E01; text-decoration: none; } @@ -150,7 +150,7 @@ hr { #latest { float: right; background: #FFD133; - box-shadow: -0.1em -0.3em 0.5em #B39223 inset; + box-shadow: -0.1em -0.3em 0.5em #795E01 inset; color: #4C3D00; border-radius: 0.5em; margin: 1em 2.2em 4em 0; @@ -208,7 +208,7 @@ hr { float: right; text-align: center; background: #F0EDE3; - color: #827A5E; + color: #3E3000; border: thin solid #CCC8B8; box-shadow: 0 0.1em 0.2em #CCC8B8 inset; border-radius: 0.5em; @@ -312,12 +312,12 @@ pre>code { } article h1 { - color: #33290A; + color: #000; margin: 0 0 0.9em 0; } article h1>a { - color: #33290A !important; + color: #000 !important; transition: none; } @@ -410,7 +410,7 @@ a.readmore:active { #contentinfo { clear: both; text-align: center; - color: #827A5E; + color: #3E3000; margin: 2em auto; padding-top: 0.5em; } @@ -450,4 +450,4 @@ th { td { border: 1px solid; padding: 5px; -} \ No newline at end of file +} -- Memet Zx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH Website v2 2/2] body.php: Add the `[lang]` attribute to the `<html>` element 2023-01-29 11:47 ` [PATCH Website v2 0/2] Fix commit messages Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 1/2] style.css: Fix background and foreground colors Memet Zx @ 2023-01-29 11:47 ` Memet Zx 2023-01-29 11:51 ` [PATCH Website v2 0/2] Fix commit messages Ammar Faizi 2 siblings, 0 replies; 8+ messages in thread From: Memet Zx @ 2023-01-29 11:47 UTC (permalink / raw) To: GNU/Weeb Mailing List; +Cc: Ammar Faizi, Irvan Malik, Memet Zx From: Memet Zx <[email protected]> If the page does not specify a language attribute, the screen reader assumes that the page is in the default language that the user selected when setting up the screen reader. this will be a problem for some people and will have difficulty pronouncing the text on the page correctly. Signed-off-by: Memet Zx <[email protected]> --- src/components/body.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/body.php b/src/components/body.php index d72ce39..8cd450b 100644 --- a/src/components/body.php +++ b/src/components/body.php @@ -1,5 +1,5 @@ <!DOCTYPE html> -<html> +<html lang="en"> <?php require __DIR__."/head.php"; ?> <body id="index" class="home"> <div id="wrapper"> -- Memet Zx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH Website v2 0/2] Fix commit messages 2023-01-29 11:47 ` [PATCH Website v2 0/2] Fix commit messages Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 1/2] style.css: Fix background and foreground colors Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 2/2] body.php: Add the `[lang]` attribute to the `<html>` element Memet Zx @ 2023-01-29 11:51 ` Ammar Faizi 2 siblings, 0 replies; 8+ messages in thread From: Ammar Faizi @ 2023-01-29 11:51 UTC (permalink / raw) To: Memet Zx, GNU/Weeb Mailing List; +Cc: Ammar Faizi, Memet Zx, Irvan Malik On Sun, 29 Jan 2023 18:47:25 +0700, Memet Zx wrote: > From: Memet Zx <[email protected]> > > hello again, > This series contains fixes to the commit message: > > # Patch 1 > > --- style.css: fixed background and foreground colors > > +++ style.css: Fix background and foreground colors > > [...] Applied, thanks! [1/2] style.css: Fix background and foreground colors commit: c33021e0f0b2a01320b4294fd31f9be83a766b9a [2/2] body.php: Add the `[lang]` attribute to the `<html>` element commit: 562a3dd5c47093c106063f1877e96e266ec0eece Best regards, -- Ammar Faizi ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-29 11:51 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-01-29 1:14 [PATCH Website v1 0/2] Improve website accessibility Memet Zx 2023-01-29 1:14 ` [PATCH Website v1 1/2] style.css: fixed background and foreground colors Memet Zx 2023-01-29 1:14 ` [PATCH Website v1 2/2] body.php: Adding the `[lang]` attribute to the `<html>` element Memet Zx 2023-01-29 11:19 ` [PATCH Website v1 0/2] Improve website accessibility Ammar Faizi 2023-01-29 11:47 ` [PATCH Website v2 0/2] Fix commit messages Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 1/2] style.css: Fix background and foreground colors Memet Zx 2023-01-29 11:47 ` [PATCH Website v2 2/2] body.php: Add the `[lang]` attribute to the `<html>` element Memet Zx 2023-01-29 11:51 ` [PATCH Website v2 0/2] Fix commit messages Ammar Faizi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox