[ammarfaizi2-block:testing/af/home 3/8] kernel/workqueue.c:4421:5: warning: no previous prototype for 'set_workqueue_cpumask'

[ammarfaizi2-block:testing/af/home 3/8] kernel/workqueue.c:4421:5: warning: no previous prototype for 'set_workqueue_cpumask'

[kernel test robot]

tree:   https://github.com/ammarfaizi2/linux-block testing/af/home
head:   51fb2efd62ae52dc061dbca301fb823357fb3f80
commit: 6436622d20b564a334e4bc0bc5019c82a592dd08 [3/8] workqueue: Add set_workqueue_cpumask() helper function
config: csky-defconfig (https://download.01.org/0day-ci/archive/20230531/202305310934.bM5gW0SL-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/6436622d20b564a334e4bc0bc5019c82a592dd08
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block testing/af/home
        git checkout 6436622d20b564a334e4bc0bc5019c82a592dd08
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=csky olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305310934.bM5gW0SL-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/workqueue.c:4421:5: warning: no previous prototype for 'set_workqueue_cpumask' [-Wmissing-prototypes]
    4421 | int set_workqueue_cpumask(struct workqueue_struct *wq, const cpumask_var_t mask)
         |     ^~~~~~~~~~~~~~~~~~~~~


vim +/set_workqueue_cpumask +4421 kernel/workqueue.c

  4420	
> 4421	int set_workqueue_cpumask(struct workqueue_struct *wq, const cpumask_var_t mask)
  4422	{
  4423		struct workqueue_attrs *tmp_attrs;
  4424		int ret;
  4425	
  4426		tmp_attrs = alloc_workqueue_attrs();
  4427		if (!tmp_attrs)
  4428			return -ENOMEM;
  4429	
  4430		apply_wqattrs_lock();
  4431		copy_workqueue_attrs(tmp_attrs, wq->unbound_attrs);
  4432		cpumask_copy(tmp_attrs->cpumask, mask);
  4433		ret = apply_workqueue_attrs_locked(wq, tmp_attrs);
  4434		apply_wqattrs_unlock();
  4435		free_workqueue_attrs(tmp_attrs);
  4436		return ret;
  4437	}
  4438	EXPORT_SYMBOL_GPL(set_workqueue_cpumask);
  4439	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [ammarfaizi2-block:testing/af/home 3/8] kernel/workqueue.c:4421:5: warning: no previous prototype for 'set_workqueue_cpumask'

[Ammar Faizi]

On Wed, May 31, 2023 at 09:24:17AM +0800, kernel test robot wrote:
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202305310934.bM5gW0SL-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> kernel/workqueue.c:4421:5: warning: no previous prototype for 'set_workqueue_cpumask' [-Wmissing-prototypes]
>     4421 | int set_workqueue_cpumask(struct workqueue_struct *wq, const cpumask_var_t mask)
>          |     ^~~~~~~~~~~~~~~~~~~~~

I forgot to add the declaration in the header. The fix below:

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index ac551b8ee7d9f2f4..e3bd6f47e74ecd66 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -710,6 +710,9 @@ int workqueue_online_cpu(unsigned int cpu);
 int workqueue_offline_cpu(unsigned int cpu);
 #endif
 
+int set_workqueue_cpumask(struct workqueue_struct *wq,
+			  const cpumask_var_t mask);
+
 void __init workqueue_init_early(void);
 void __init workqueue_init(void);
 

-- 
Ammar Faizi