From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v1 00/15] Everything about logger changes and some fixes
Date: Wed, 18 Jan 2023 06:29:31 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 18/01/2023 06.10, Ammar Faizi wrote:
> On Wed, Jan 18, 2023 at 05:12:01AM +0700, Muhammad Rizki wrote:
>> Hi sir,
>> This series is about refactor logger method, fix charset issue, and some
>> improvements. In this series we use a simple logging method that so
>> easily to manage logger config using .conf file.
>>
>> - What's new?
>> v1:
>> 1) Add return type annotation for the send_text_mail() and
>> send_patch_email() for the Discord bot
>
> This one breaks runtime:
>
> Traceback (most recent call last):
> File "/root/lore-daemon2/daemon/tg.py", line 11, in <module>
> from telegram.packages import DaemonTelegram
> File "/root/lore-daemon2/daemon/telegram/packages/__init__.py", line 1, in <module>
> from .client import DaemonTelegram
> File "/root/lore-daemon2/daemon/telegram/packages/client.py", line 17, in <module>
> from .decorator import handle_flood
> File "/root/lore-daemon2/daemon/telegram/packages/decorator.py", line 8, in <module>
> from typing_extensions import ParamSpec, ParamSpecArgs, ParamSpecKwargs
> ModuleNotFoundError: No module named 'typing_extensions'
>
> Apparently, that happens because 'typing_extensions' module is missing.
> But you didn't add that to the requirements.txt file. Apart from that,
> I don't see anything immediately wrong. Overall, it looks good to me.
>
> Please update the requirements.txt file together with that module
> import addition.
>
My bad, I thought `typing_extensions` is a built-in library.
I realised that we only have 1 `requirements.txt` and it's in the
`telegram` directory. Should we move it to the root `daemon` directory
and update the `requirements.txt`?
next prev parent reply other threads:[~2023-01-17 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 22:12 [PATCH v1 00/15] Everything about logger changes and some fixes Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 01/15] telegram: Simplify code to get DB_PORT from env Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 02/15] discord: " Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 03/15] telegram: logger: Add a telegram.logger.conf Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 04/15] discord: logger: Add a discord.logger.conf Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 05/15] telegram: logger: Initialize the configuration for the Telegram logger Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 06/15] discord: logger: Initialize the configuration for the Discord logger Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 07/15] telegram: fix: Fix the type annoations for the decorator Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 08/15] discord: cleanup: Remove some unnecessary comments Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 09/15] discord: fix: Fix the type annotations for the decorator Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 10/15] discord: typing: Add return type annotations Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 11/15] telegram: Implement DaemonException() and report_err() in scrape.py Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 12/15] utils: fix: Fix charset issue for get_decoded_payload() Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 13/15] telegram: logger: Refactor all logging method Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 14/15] discord: Implement DaemonException and report_err in get_lore_mail.py Muhammad Rizki
2023-01-17 22:12 ` [PATCH v1 15/15] discord: logger: Refactor all logging method Muhammad Rizki
2023-01-17 23:10 ` [PATCH v1 00/15] Everything about logger changes and some fixes Ammar Faizi
2023-01-17 23:29 ` Muhammad Rizki [this message]
2023-01-17 23:31 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox