GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
From: Paolo Abeni <[email protected]>
To: Alejandro Lucero <[email protected]>
Cc: [email protected],
	Ammar Faizi <[email protected]>,
	 GNU/Weeb Mailing List <[email protected]>,
	Jiri Pirko <[email protected]>, kernel test robot <[email protected]>
Subject: Re: [ammarfaizi2-block:netdev/net-next/master 27/39] drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id'
Date: Thu, 16 Feb 2023 18:34:30 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Fri, 2023-02-17 at 00:12 +0800, kernel test robot wrote:
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <[email protected]>
> > Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/net/ethernet/sfc/efx_devlink.c: In function 'efx_devlink_info_running_v2':
> > > drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id'
>      185 |                 memset(&build_date, 0, sizeof(build_date)
>          |                       ~                                  ^
>          |                                                          )
>      186 | #endif
>      187 |                 build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>          |                 ~~~~~~~~                                  
> > > drivers/net/ethernet/sfc/efx_devlink.c:197:55: error: expected ';' before '}' token
>      197 |                                                  buf);
>          |                                                       ^
>          |                                                       ;
>      198 |         }
>          |         ~                                              

Alejandro, the bottom line is that your series need a follow-up as it
breaks the build when CONFIG_RTC_LIB is not defined. I missed that at
code review time.

Could you please sent a fix (for net-next?)

Thanks!

Paolo


  reply	other threads:[~2023-02-16 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 16:12 [ammarfaizi2-block:netdev/net-next/master 27/39] drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id' kernel test robot
2023-02-16 17:34 ` Paolo Abeni [this message]
2023-02-17  9:43   ` Lucero Palau, Alejandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea3b86d9f06af4a9261d7c698c7b9a4e1ca35ccd.camel@redhat.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox