From: Jakub Kicinski <kuba@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early
Date: Thu, 6 Aug 2026 07:07:14 -0700 [thread overview]
Message-ID: <20260806070714.5ee4d932@kernel.org> (raw)
In-Reply-To: <511377bc-7703-410a-8982-3050ad27c066@kernel.dk>
On Thu, 6 Aug 2026 07:51:22 -0600 Jens Axboe wrote:
> On 8/6/26 7:49 AM, Jakub Kicinski wrote:
> > On Thu, 06 Aug 2026 06:00:49 -0600 Jens Axboe wrote:
> >> Applied, thanks!
> >>
> >> [1/1] io_uring/zcrx: fail non-qops netdevs early
> >> commit: cf7aa48151deb629022a8b0c61c139dbfa579933
> >
> > I asked for a different fix :/
> >
> > https://lore.kernel.org/all/20260805165817.7e1fc367@kernel.org/
> >
> > Outside subsystems should not be poking at random fields and making
> > guesses. The assert is simply wrong and should be changed.
> >
> > Jens, can you drop this please?
>
> Sure, dropped.
Thank you! We'll probably ship the fix next week, FWIW. This week's PR
is imminent, don't want to rush it.
prev parent reply other threads:[~2026-08-06 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 11:42 [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early Pavel Begunkov
2026-08-06 12:00 ` Jens Axboe
2026-08-06 13:49 ` Jakub Kicinski
2026-08-06 13:51 ` Jens Axboe
2026-08-06 14:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806070714.5ee4d932@kernel.org \
--to=kuba@kernel.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox