* [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early
@ 2026-08-06 11:42 Pavel Begunkov
2026-08-06 12:00 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Begunkov @ 2026-08-06 11:42 UTC (permalink / raw)
To: io-uring; +Cc: asml.silence, netdev, Jakub Kicinski
netdev_get_by_index_lock() might return a netdev that doesn't have qops
and also relies on rtnl. We're going to reject it later when opening a
queue, but netdev_queue_get_dma_dev() warns before that. Reject non-qops
netdevs earlier for now.
RTNL: assertion failed at ./include/net/netdev_lock.h (72)
WARNING: ./include/net/netdev_lock.h:72 at netdev_assert_locked_ops_compat
include/net/netdev_lock.h:72 [inline]
WARNING: ./include/net/netdev_lock.h:72 at netdev_queue_get_dma_dev+0x52e/0x660
net/core/netdev_queues.c:43,
RIP: 0010:netdev_assert_locked_ops_compat include/net/netdev_lock.h:72 [inline]
RIP: 0010:netdev_queue_get_dma_dev+0x53a/0x660 net/core/netdev_queues.c:43
Call Trace:
<TASK>
zcrx_register_netdev io_uring/zcrx.c:831 [inline]
io_register_zcrx+0xe94/0x1d30 io_uring/zcrx.c:983
__io_uring_register io_uring/register.c:942 [inline]
__do_sys_io_uring_register+0x1193/0x1bc0 io_uring/register.c:1040
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Cc: stable@vger.kernel.org
Fixes: b6c5f9454ef34 ("io_uring/zcrx: call netdev_queue_get_dma_dev() under instance lock")
Reported-by: syzbot+a78926bdac2adb52dc0e@syzkaller.appspotmail.com
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/zcrx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
index f1464ea8ca64..add91d6d6e52 100644
--- a/io_uring/zcrx.c
+++ b/io_uring/zcrx.c
@@ -825,6 +825,10 @@ static int zcrx_register_netdev(struct io_zcrx_ifq *ifq,
reg->if_idx);
if (!ifq->netdev)
return -ENODEV;
+ if (!ifq->netdev->queue_mgmt_ops) {
+ ret = -EOPNOTSUPP;
+ goto netdev_put_unlock;
+ }
netdev_hold(ifq->netdev, &ifq->netdev_tracker, GFP_KERNEL);
--
2.54.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early
2026-08-06 11:42 [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early Pavel Begunkov
@ 2026-08-06 12:00 ` Jens Axboe
2026-08-06 13:49 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2026-08-06 12:00 UTC (permalink / raw)
To: io-uring, Pavel Begunkov; +Cc: netdev, Jakub Kicinski
On Thu, 06 Aug 2026 12:42:33 +0100, Pavel Begunkov wrote:
> netdev_get_by_index_lock() might return a netdev that doesn't have qops
> and also relies on rtnl. We're going to reject it later when opening a
> queue, but netdev_queue_get_dma_dev() warns before that. Reject non-qops
> netdevs earlier for now.
>
> RTNL: assertion failed at ./include/net/netdev_lock.h (72)
> WARNING: ./include/net/netdev_lock.h:72 at netdev_assert_locked_ops_compat
> include/net/netdev_lock.h:72 [inline]
> WARNING: ./include/net/netdev_lock.h:72 at netdev_queue_get_dma_dev+0x52e/0x660
> net/core/netdev_queues.c:43,
> RIP: 0010:netdev_assert_locked_ops_compat include/net/netdev_lock.h:72 [inline]
> RIP: 0010:netdev_queue_get_dma_dev+0x53a/0x660 net/core/netdev_queues.c:43
> Call Trace:
> <TASK>
> zcrx_register_netdev io_uring/zcrx.c:831 [inline]
> io_register_zcrx+0xe94/0x1d30 io_uring/zcrx.c:983
> __io_uring_register io_uring/register.c:942 [inline]
> __do_sys_io_uring_register+0x1193/0x1bc0 io_uring/register.c:1040
> do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> [...]
Applied, thanks!
[1/1] io_uring/zcrx: fail non-qops netdevs early
commit: cf7aa48151deb629022a8b0c61c139dbfa579933
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early
2026-08-06 12:00 ` Jens Axboe
@ 2026-08-06 13:49 ` Jakub Kicinski
2026-08-06 13:51 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2026-08-06 13:49 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring, Pavel Begunkov, netdev
On Thu, 06 Aug 2026 06:00:49 -0600 Jens Axboe wrote:
> On Thu, 06 Aug 2026 12:42:33 +0100, Pavel Begunkov wrote:
> > netdev_get_by_index_lock() might return a netdev that doesn't have qops
> > and also relies on rtnl. We're going to reject it later when opening a
> > queue, but netdev_queue_get_dma_dev() warns before that. Reject non-qops
> > netdevs earlier for now.
> >
> > RTNL: assertion failed at ./include/net/netdev_lock.h (72)
> > WARNING: ./include/net/netdev_lock.h:72 at netdev_assert_locked_ops_compat
> > include/net/netdev_lock.h:72 [inline]
> > WARNING: ./include/net/netdev_lock.h:72 at netdev_queue_get_dma_dev+0x52e/0x660
> > net/core/netdev_queues.c:43,
> > RIP: 0010:netdev_assert_locked_ops_compat include/net/netdev_lock.h:72 [inline]
> > RIP: 0010:netdev_queue_get_dma_dev+0x53a/0x660 net/core/netdev_queues.c:43
> > Call Trace:
> > <TASK>
> > zcrx_register_netdev io_uring/zcrx.c:831 [inline]
> > io_register_zcrx+0xe94/0x1d30 io_uring/zcrx.c:983
> > __io_uring_register io_uring/register.c:942 [inline]
> > __do_sys_io_uring_register+0x1193/0x1bc0 io_uring/register.c:1040
> > do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> > do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
> > entry_SYSCALL_64_after_hwframe+0x77/0x7f
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] io_uring/zcrx: fail non-qops netdevs early
> commit: cf7aa48151deb629022a8b0c61c139dbfa579933
I asked for a different fix :/
https://lore.kernel.org/all/20260805165817.7e1fc367@kernel.org/
Outside subsystems should not be poking at random fields and making
guesses. The assert is simply wrong and should be changed.
Jens, can you drop this please?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early
2026-08-06 13:49 ` Jakub Kicinski
@ 2026-08-06 13:51 ` Jens Axboe
2026-08-06 14:07 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2026-08-06 13:51 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: io-uring, Pavel Begunkov, netdev
On 8/6/26 7:49 AM, Jakub Kicinski wrote:
> On Thu, 06 Aug 2026 06:00:49 -0600 Jens Axboe wrote:
>> On Thu, 06 Aug 2026 12:42:33 +0100, Pavel Begunkov wrote:
>>> netdev_get_by_index_lock() might return a netdev that doesn't have qops
>>> and also relies on rtnl. We're going to reject it later when opening a
>>> queue, but netdev_queue_get_dma_dev() warns before that. Reject non-qops
>>> netdevs earlier for now.
>>>
>>> RTNL: assertion failed at ./include/net/netdev_lock.h (72)
>>> WARNING: ./include/net/netdev_lock.h:72 at netdev_assert_locked_ops_compat
>>> include/net/netdev_lock.h:72 [inline]
>>> WARNING: ./include/net/netdev_lock.h:72 at netdev_queue_get_dma_dev+0x52e/0x660
>>> net/core/netdev_queues.c:43,
>>> RIP: 0010:netdev_assert_locked_ops_compat include/net/netdev_lock.h:72 [inline]
>>> RIP: 0010:netdev_queue_get_dma_dev+0x53a/0x660 net/core/netdev_queues.c:43
>>> Call Trace:
>>> <TASK>
>>> zcrx_register_netdev io_uring/zcrx.c:831 [inline]
>>> io_register_zcrx+0xe94/0x1d30 io_uring/zcrx.c:983
>>> __io_uring_register io_uring/register.c:942 [inline]
>>> __do_sys_io_uring_register+0x1193/0x1bc0 io_uring/register.c:1040
>>> do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
>>> do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
>>> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] io_uring/zcrx: fail non-qops netdevs early
>> commit: cf7aa48151deb629022a8b0c61c139dbfa579933
>
> I asked for a different fix :/
>
> https://lore.kernel.org/all/20260805165817.7e1fc367@kernel.org/
>
> Outside subsystems should not be poking at random fields and making
> guesses. The assert is simply wrong and should be changed.
>
> Jens, can you drop this please?
Sure, dropped.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early
2026-08-06 13:51 ` Jens Axboe
@ 2026-08-06 14:07 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2026-08-06 14:07 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring, Pavel Begunkov, netdev
On Thu, 6 Aug 2026 07:51:22 -0600 Jens Axboe wrote:
> On 8/6/26 7:49 AM, Jakub Kicinski wrote:
> > On Thu, 06 Aug 2026 06:00:49 -0600 Jens Axboe wrote:
> >> Applied, thanks!
> >>
> >> [1/1] io_uring/zcrx: fail non-qops netdevs early
> >> commit: cf7aa48151deb629022a8b0c61c139dbfa579933
> >
> > I asked for a different fix :/
> >
> > https://lore.kernel.org/all/20260805165817.7e1fc367@kernel.org/
> >
> > Outside subsystems should not be poking at random fields and making
> > guesses. The assert is simply wrong and should be changed.
> >
> > Jens, can you drop this please?
>
> Sure, dropped.
Thank you! We'll probably ship the fix next week, FWIW. This week's PR
is imminent, don't want to rush it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-06 14:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 11:42 [PATCH io_uring-7.2 1/1] io_uring/zcrx: fail non-qops netdevs early Pavel Begunkov
2026-08-06 12:00 ` Jens Axboe
2026-08-06 13:49 ` Jakub Kicinski
2026-08-06 13:51 ` Jens Axboe
2026-08-06 14:07 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox