From: Gabriel Krisman Bertazi <krisman@suse.de>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, Gabriel Krisman Bertazi <krisman@suse.de>
Subject: [PATCH 1/3] io_uring/rw: Drop custom iov copy in io_iov_buffer_select_prep
Date: Wed, 12 Aug 2026 20:40:20 -0400 [thread overview]
Message-ID: <20260813004022.3514537-2-krisman@suse.de> (raw)
In-Reply-To: <20260813004022.3514537-1-krisman@suse.de>
Similar to commit f4eaf8eda89e ("io_uring/rsrc: Drop io_copy_iov in
favor of iovec API"), avoid custom copy and just rely on the iovec api.
Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
---
io_uring/rw.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/io_uring/rw.c b/io_uring/rw.c
index 95038cfda615..95106dd1d7eb 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -9,7 +9,6 @@
#include <linux/fsnotify.h>
#include <linux/poll.h>
#include <linux/nospec.h>
-#include <linux/compat.h>
#include <linux/io_uring/cmd.h>
#include <linux/indirect_call_wrapper.h>
@@ -50,33 +49,20 @@ static bool io_file_supports_nowait(struct io_kiocb *req, __poll_t mask)
return false;
}
-static int io_iov_compat_buffer_select_prep(struct io_rw *rw)
-{
- struct compat_iovec __user *uiov = u64_to_user_ptr(rw->addr);
- struct compat_iovec iov;
-
- if (copy_from_user(&iov, uiov, sizeof(iov)))
- return -EFAULT;
- rw->len = iov.iov_len;
- return 0;
-}
-
static int io_iov_buffer_select_prep(struct io_kiocb *req)
{
struct iovec __user *uiov;
- struct iovec iov;
+ struct iovec fast_iov, *iov;
struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw);
if (rw->len != 1)
return -EINVAL;
- if (io_is_compat(req->ctx))
- return io_iov_compat_buffer_select_prep(rw);
-
uiov = u64_to_user_ptr(rw->addr);
- if (copy_from_user(&iov, uiov, sizeof(*uiov)))
- return -EFAULT;
- rw->len = iov.iov_len;
+ iov = iovec_from_user(uiov, 1, 1, &fast_iov, io_is_compat(req->ctx));
+ if (IS_ERR(iov))
+ return PTR_ERR(iov);
+ rw->len = iov->iov_len;
return 0;
}
--
2.55.0
next prev parent reply other threads:[~2026-08-13 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 0:40 [PATCH 0/3] Continue iovec api clean up Gabriel Krisman Bertazi
2026-08-13 0:40 ` Gabriel Krisman Bertazi [this message]
2026-08-13 0:40 ` [PATCH 2/3] io_uring/net: Drop custom iov copy in io_msg_copy_hdr Gabriel Krisman Bertazi
2026-08-13 0:40 ` [PATCH 3/3] io_uring/net: Drop ddir argument from io_msg_copy_hdr Gabriel Krisman Bertazi
2026-08-16 0:02 ` [PATCH 0/3] Continue iovec api clean up Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813004022.3514537-2-krisman@suse.de \
--to=krisman@suse.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox