From: Gabriel Krisman Bertazi <krisman@suse.de>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, Gabriel Krisman Bertazi <krisman@suse.de>
Subject: [PATCH 3/3] io_uring/net: Drop ddir argument from io_msg_copy_hdr
Date: Wed, 12 Aug 2026 20:40:22 -0400 [thread overview]
Message-ID: <20260813004022.3514537-4-krisman@suse.de> (raw)
In-Reply-To: <20260813004022.3514537-1-krisman@suse.de>
ddir was only ever forwarded to io_compat_msg_copy_hdr, which
never looked at it. Drop it.
Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
---
io_uring/net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/io_uring/net.c b/io_uring/net.c
index f476399e1d63..3f04aa1054c6 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -255,7 +255,7 @@ static int io_copy_msghdr_from_user(struct user_msghdr *msg,
}
static int io_msg_copy_hdr(struct io_kiocb *req, struct io_async_msghdr *iomsg,
- struct user_msghdr *msg, int ddir,
+ struct user_msghdr *msg,
struct sockaddr __user **save_addr)
{
struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg);
@@ -371,7 +371,7 @@ static int io_sendmsg_setup(struct io_kiocb *req, const struct io_uring_sqe *sqe
sr->flags |= IORING_SEND_VECTORIZED;
sr->umsg = u64_to_user_ptr(READ_ONCE(sqe->addr));
- ret = io_msg_copy_hdr(req, kmsg, &msg, ITER_SOURCE, NULL);
+ ret = io_msg_copy_hdr(req, kmsg, &msg, NULL);
if (unlikely(ret))
return ret;
/* save msg_control as sys_sendmsg() overwrites it */
@@ -730,7 +730,7 @@ static int io_recvmsg_copy_hdr(struct io_kiocb *req,
struct user_msghdr msg;
int ret;
- ret = io_msg_copy_hdr(req, iomsg, &msg, ITER_DEST, &iomsg->uaddr);
+ ret = io_msg_copy_hdr(req, iomsg, &msg, &iomsg->uaddr);
if (unlikely(ret))
return ret;
--
2.55.0
next prev parent reply other threads:[~2026-08-13 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 0:40 [PATCH 0/3] Continue iovec api clean up Gabriel Krisman Bertazi
2026-08-13 0:40 ` [PATCH 1/3] io_uring/rw: Drop custom iov copy in io_iov_buffer_select_prep Gabriel Krisman Bertazi
2026-08-13 0:40 ` [PATCH 2/3] io_uring/net: Drop custom iov copy in io_msg_copy_hdr Gabriel Krisman Bertazi
2026-08-13 0:40 ` Gabriel Krisman Bertazi [this message]
2026-08-16 0:02 ` [PATCH 0/3] Continue iovec api clean up Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813004022.3514537-4-krisman@suse.de \
--to=krisman@suse.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox