From: Pavel Begunkov <[email protected]>
To: Breno Leitao <[email protected]>,
[email protected], [email protected],
[email protected], [email protected], [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH v4 0/3] io_uring: Pass the whole sqe to commands
Date: Thu, 4 May 2023 15:09:48 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 5/4/23 13:18, Breno Leitao wrote:
> These three patches prepare for the sock support in the io_uring cmd, as
> described in the following RFC:
It doesn't apply, seems there are conflicts with ublk, but
looks good otherwise.
Reviewed-by: Pavel Begunkov <[email protected]>
> Link: https://lore.kernel.org/lkml/[email protected]/
>
> Since the support linked above depends on other refactors, such as the sock
> ioctl() sock refactor, I would like to start integrating patches that have
> consensus and can bring value right now. This will also reduce the
> patchset size later.
>
> Regarding to these three patches, they are simple changes that turn
> io_uring cmd subsystem more flexible (by passing the whole SQE to the
> command), and cleaning up an unnecessary compile check.
>
> These patches were tested by creating a file system and mounting an NVME disk
> using ubdsrv/ublkb0.
>
> Reviewed-by: Kanchan Joshi <[email protected]>
>
> V1 -> V2 :
> * Create a helper to return the size of the SQE
> V2 -> V3:
> * Transformed uring_sqe_size() into a proper function
> * Fixed some commit messages
> * Created a helper function for nvme/host to avoid casting
> * Added a fourth patch to avoid ublk_drv's casts by using a proper helper
> V3 -> V4:
> * Create a function that returns a null pointer (io_uring_sqe_cmd()),
> and uses it to get the cmd private data from the sqe.
>
> Breno Leitao (3):
> io_uring: Create a helper to return the SQE size
> io_uring: Pass whole sqe to commands
> io_uring: Remove unnecessary BUILD_BUG_ON
>
> drivers/block/ublk_drv.c | 26 +++++++++++++-------------
> drivers/nvme/host/ioctl.c | 2 +-
> include/linux/io_uring.h | 7 ++++++-
> io_uring/io_uring.h | 10 ++++++++++
> io_uring/opdef.c | 2 +-
> io_uring/uring_cmd.c | 12 +++---------
> io_uring/uring_cmd.h | 8 --------
> 7 files changed, 34 insertions(+), 33 deletions(-)
>
--
Pavel Begunkov
next prev parent reply other threads:[~2023-05-04 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 12:18 [PATCH v4 0/3] io_uring: Pass the whole sqe to commands Breno Leitao
2023-05-04 12:18 ` [PATCH v4 1/3] io_uring: Create a helper to return the SQE size Breno Leitao
2023-05-04 14:39 ` Ming Lei
2023-05-04 12:18 ` [PATCH v4 2/3] io_uring: Pass whole sqe to commands Breno Leitao
2023-05-04 13:55 ` Christoph Hellwig
2023-05-04 14:04 ` Pavel Begunkov
2023-05-04 14:29 ` Ming Lei
2023-05-04 12:18 ` [PATCH v4 3/3] io_uring: Remove unnecessary BUILD_BUG_ON Breno Leitao
2023-05-04 14:40 ` Ming Lei
2023-05-04 14:09 ` Pavel Begunkov [this message]
2023-05-04 17:51 ` [PATCH v4 0/3] io_uring: Pass the whole sqe to commands Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox