public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ming Lei <[email protected]>
To: Breno Leitao <[email protected]>
Cc: [email protected], [email protected],
	[email protected], [email protected], [email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected], [email protected]
Subject: Re: [PATCH v4 2/3] io_uring: Pass whole sqe to commands
Date: Thu, 4 May 2023 22:29:09 +0800	[thread overview]
Message-ID: <ZFPBNWx6ZqYxiqB/> (raw)
In-Reply-To: <[email protected]>

On Thu, May 04, 2023 at 05:18:55AM -0700, Breno Leitao wrote:
> Currently uring CMD operation relies on having large SQEs, but future
> operations might want to use normal SQE.
> The io_uring_cmd currently only saves the payload (cmd) part of the SQE,
> but, for commands that use normal SQE size, it might be necessary to
> access the initial SQE fields outside of the payload/cmd block.  So,

Looks fine,

Reviewed-by: Ming Lei <[email protected]>

BTW, there might be risk[1] when accessing SQE fields which were read by
io_uring core code, and I'd suggest to document it in future.

[1][email protected]/


  parent reply	other threads:[~2023-05-04 14:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 12:18 [PATCH v4 0/3] io_uring: Pass the whole sqe to commands Breno Leitao
2023-05-04 12:18 ` [PATCH v4 1/3] io_uring: Create a helper to return the SQE size Breno Leitao
2023-05-04 14:39   ` Ming Lei
2023-05-04 12:18 ` [PATCH v4 2/3] io_uring: Pass whole sqe to commands Breno Leitao
2023-05-04 13:55   ` Christoph Hellwig
2023-05-04 14:04   ` Pavel Begunkov
2023-05-04 14:29   ` Ming Lei [this message]
2023-05-04 12:18 ` [PATCH v4 3/3] io_uring: Remove unnecessary BUILD_BUG_ON Breno Leitao
2023-05-04 14:40   ` Ming Lei
2023-05-04 14:09 ` [PATCH v4 0/3] io_uring: Pass the whole sqe to commands Pavel Begunkov
2023-05-04 17:51 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFPBNWx6ZqYxiqB/ \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox