From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
NeilBrown <neil@brown.name>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org, io-uring@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/7] fork: refuse new threads while a coredump or an exec is in progress
Date: Fri, 18 Sep 2026 15:41:42 +0200 [thread overview]
Message-ID: <aq0_lvHDViIpX_Mu@redhat.com> (raw)
In-Reply-To: <20260918-disput-maden-parkdeck-2bc22dd90398@brauner>
On 09/18, Christian Brauner wrote:
>
> I think this works but they also need to check ->in_execve as the
> exec'ing thread is obviously never signaled:
>
> @@ -2709,6 +2707,10 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
> .user_worker = 1,
> };
>
> + /* A creator past its fatal signal or in execve gets no thread. */
> + if ((current->flags & PF_SIGNALED) || current->in_execve)
> + return ERR_PTR(-EINTR);
Ah, I forgot to mention...
Can we shift io_uring_task_cancel() up, after setting bprm->point_of_no_return
but before de_thread() ?
I know nothing about io_uring, not sure this would be enough...
Oleg.
next prev parent reply other threads:[~2026-09-18 13:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:17 [PATCH v2 0/7] coredump & signals: an impossible affair Christian Brauner
2026-09-17 9:17 ` [PATCH v2 1/7] fork: refuse new threads while a coredump or an exec is in progress Christian Brauner
2026-09-17 16:33 ` Bradley Morgan
2026-09-18 10:40 ` Oleg Nesterov
2026-09-18 12:24 ` Christian Brauner
2026-09-18 12:52 ` Christian Brauner
2026-09-18 13:41 ` Oleg Nesterov [this message]
2026-09-18 14:29 ` Christian Brauner
2026-09-18 15:00 ` Christian Brauner
2026-09-18 15:15 ` Christian Brauner
2026-09-21 10:32 ` Oleg Nesterov
2026-09-21 11:46 ` Christian Brauner
2026-09-21 12:37 ` Oleg Nesterov
2026-09-17 9:17 ` [PATCH v2 2/7] coredump: hold RCU while releasing parked threads Christian Brauner
2026-09-17 9:17 ` [PATCH v2 3/7] signal: only SIGKILL and the freezers interrupt a coredumping task Christian Brauner
2026-09-17 9:17 ` [PATCH v2 4/7] coredump: parse a snapshot of core_pattern Christian Brauner
2026-09-18 15:28 ` Oleg Nesterov
2026-09-17 9:17 ` [PATCH v2 5/7] io-wq: order the exit bit against worker creation task work Christian Brauner
2026-09-18 14:55 ` Oleg Nesterov
2026-09-17 9:17 ` [PATCH v2 6/7] signal: don't retarget shared signals in a dying thread group Christian Brauner
2026-09-18 14:24 ` Oleg Nesterov
2026-09-17 9:17 ` [PATCH v2 7/7] selftests/coredump: test shared signal retargeting during a dump Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq0_lvHDViIpX_Mu@redhat.com \
--to=oleg@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=neil@brown.name \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox