* io_wq_worker_wake() calls ttwu() twice if TIF_NOTIFY_SIGNAL is not set
@ 2026-09-27 9:56 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2026-09-27 9:56 UTC (permalink / raw)
To: Christian Brauner, Jens Axboe, Pavel Begunkov; +Cc: io-uring
I can't understand what this trivial helper is trying to do.
Does it really need to set TIF_NOTIFY_SIGNAL and do the unconditonal
wakeup including TASK_UNINTERRUPTIBLE? In this case in can just do
static bool io_wq_worker_wake(struct io_worker *worker, void *data)
{
set_tsk_thread_flag(worker->task, TIF_NOTIFY_SIGNAL);
wake_up_process(worker->task);
return false;
}
Or may be it can rely on __set_notify_signal() which does
wake_up_state(TASK_INTERRUPTIBLE) if TIF_NOTIFY_SIGNAL is not set?
Then wake_up_process() should be removed.
Confused ;)
Oleg.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-27 9:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-27 9:56 io_wq_worker_wake() calls ttwu() twice if TIF_NOTIFY_SIGNAL is not set Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox