public inbox for [email protected]
 help / color / mirror / Atom feed
From: Olivier Langlois <[email protected]>
To: Jens Axboe <[email protected]>, Stefan Roesch <[email protected]>,
	 [email protected], [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH v15 0/7] io_uring: add napi busy polling support
Date: Wed, 31 Jan 2024 14:56:04 -0500	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Wed, 2024-01-31 at 12:59 -0500, Olivier Langlois wrote:
> On Wed, 2024-01-31 at 10:32 -0700, Jens Axboe wrote:
> > 
> > Thanks for testing!
> > 
> > Any chance that you could run some tests with and without NAPI that
> > help
> > validate that it actually works? That part is what I'm most
> > interested
> > in, not too worried about the stability of it as I have scrutinized
> > it
> > pretty close already.
> > 
> 
> There is maybe a test that I can perform. The data that I receive is
> timestamped. I have a small test program that checks the age of the
> updates on their reception...
> 
> I would expect that it should be possible to perceive the busy
> polling
> effect by comparing the average update age with and without the
> feature
> enabled...
> 
> A word of warning... The service that my client is connecting to has
> relocated recently. I used to have an RTT of about 8mSec with it to
> about 400-500 mSec today...
> 
> because of the huge RTT, I am unsure that the test is going to be
> conclusive at all...
> 
> However, I am also in the process of relocating my client closer to
> the
> service. If you can wait a week or so, I should able to do that test
> with a RTT < 1 mSec...
> 
> Beside that, I could redo the same test that Stefan did with the ping
> client/server setup but would that test add any value to the current
> collective knowledge?
> 
> I'll do the update age test when I restart my client and I'll report
> back the result but my expectations aren't very high that it is going
> to be conclusive due to the huge RTT.
> 
> 
As I expected, the busy polling difference in the update age test is so
small compared to the RTT that the result is inconclusive, IMHO...

The number of collected updates to build the stats is 500.

System clocks are assumed to be synchronized and the RTT is the
difference between the local time and the update timestamp.
Actually, it may be more accurate to say that the displayed RTT values
are in fact TT...

latency NO napi busy poll:
[2024-01-31 11:28:34] INFO Main/processCollectedData rtt
min/avg/max/mdev = 74.509/76.752/115.969/3.110 ms

latency napi busy poll:
[2024-01-31 11:33:05] INFO Main/processCollectedData rtt
min/avg/max/mdev = 75.347/76.740/134.588/1.648 ms

I'll redo the test once my RTT is closer to 1mSec. The relative gain
should be more impressive...


  reply	other threads:[~2024-01-31 19:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 16:38 [PATCH v15 0/7] io_uring: add napi busy polling support Stefan Roesch
2023-06-08 16:38 ` [PATCH v15 1/7] net: split off __napi_busy_poll from napi_busy_poll Stefan Roesch
2023-06-08 19:33   ` kernel test robot
2023-06-08 16:38 ` [PATCH v15 2/7] net: add napi_busy_loop_rcu() Stefan Roesch
2023-06-08 16:38 ` [PATCH v15 3/7] io-uring: move io_wait_queue definition to header file Stefan Roesch
2023-06-08 16:38 ` [PATCH v15 4/7] io-uring: add napi busy poll support Stefan Roesch
2023-06-08 16:38 ` [PATCH v15 5/7] io-uring: add sqpoll support for napi busy poll Stefan Roesch
2023-06-08 16:38 ` [PATCH v15 6/7] io_uring: add register/unregister napi function Stefan Roesch
2023-06-08 16:38 ` [PATCH v15 7/7] io_uring: add prefer busy poll to register and unregister napi api Stefan Roesch
2024-01-30 21:20 ` [PATCH v15 0/7] io_uring: add napi busy polling support Olivier Langlois
2024-01-30 22:59   ` Jens Axboe
2024-01-31  5:30     ` Olivier Langlois
2024-01-31 17:22     ` Olivier Langlois
2024-01-31 17:32       ` Jens Axboe
2024-01-31 17:59         ` Olivier Langlois
2024-01-31 19:56           ` Olivier Langlois [this message]
2024-01-31 20:52             ` Jens Axboe
2024-01-31 21:03               ` Olivier Langlois
2024-02-02 20:20               ` Olivier Langlois
2024-02-02 22:58                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c28b3f5f40ed028ba9d74e94e3cc826c04f38bf7.camel@trillion01.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox