public inbox for [email protected]
 help / color / mirror / Atom feed
From: Olivier Langlois <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Stefan Roesch <[email protected]>,
	[email protected],  [email protected],
	[email protected]
Subject: Re: [PATCH v9 1/4] liburing: add api to set napi busy poll settings
Date: Fri, 02 Feb 2024 15:11:40 -0500	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Fri, 2024-02-02 at 10:48 -0700, Jens Axboe wrote:
> On Feb 2, 2024, at 10:41 AM, Olivier Langlois
> <[email protected]> wrote:
> > 
> > On Fri, 2024-02-02 at 09:42 -0700, Jens Axboe wrote:
> > > > On 2/2/24 9:41 AM, Olivier Langlois wrote:
> > > > On Tue, 2023-04-25 at 11:20 -0700, Stefan Roesch wrote:
> > > > > +
> > > > > +int io_uring_register_napi(struct io_uring *ring, struct
> > > > > io_uring_napi *napi)
> > > > > +{
> > > > > +    return __sys_io_uring_register(ring->ring_fd,
> > > > > +                IORING_REGISTER_NAPI, napi, 0);
> > > > > +}
> > > > > +
> > > > > +int io_uring_unregister_napi(struct io_uring *ring, struct
> > > > > io_uring_napi *napi)
> > > > > +{
> > > > > +    return __sys_io_uring_register(ring->ring_fd,
> > > > > +                IORING_UNREGISTER_NAPI, napi,
> > > > > 0);
> > > > > +}
> > > > 
> > > > my apologies if this is not the latest version of the patch but
> > > > I
> > > > think
> > > > that it is...
> > > > 
> > > > nr_args should be 1 to match what __io_uring_register() in the
> > > > current
> > > > corresponding kernel patch expects:
> > > > 
> > > > https://git.kernel.dk/cgit/linux/commit/?h=io_uring-napi&id=787d81d3132aaf4eb4a4a5f24ff949e350e537d0
> > > 
> > > Can you send a patch I can fold in?
> > > 
> > Jens,
> > 
> > I am unsure of what you are asking me.
> > 
> > You would like me to send a patch to fix a liburing patch that has
> > never been applied AFAIK?
> > 
> > if the v9 patch has never been applied. Wouldn't just editing
> > Stefan
> > patch by replacing the nr_args param from 0 to 1 directly do it?
> 
> The current version is what is in that branch you referenced. If you
> see anything in there that needs changing, send a patch for that. 
> 
> I can send out the series again if needed.
> 
AFAIK, the kernel patch is fine.

my comment was referring the liburing patch that is calling
__sys_io_uring_register() by passing a nr_args value of 0.

This is problematic because on the kernel side, io_uring_register()
returns -EINVAL if nr_args is not 1.


  reply	other threads:[~2024-02-02 20:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 18:20 [PATCH v9 0/4] liburing: add api for napi busy poll Stefan Roesch
2023-04-25 18:20 ` [PATCH v9 1/4] liburing: add api to set napi busy poll settings Stefan Roesch
2024-02-02 16:41   ` Olivier Langlois
2024-02-02 16:42     ` Jens Axboe
2024-02-02 17:41       ` Olivier Langlois
2024-02-02 17:48         ` Jens Axboe
2024-02-02 20:11           ` Olivier Langlois [this message]
2024-02-02 20:14             ` Jens Axboe
2024-02-02 20:23               ` Olivier Langlois
2024-02-02 22:20                 ` Jens Axboe
2024-02-02 22:46                   ` Jens Axboe
2024-02-03  2:30                     ` Jens Axboe
2023-04-25 18:20 ` [PATCH v9 2/4] liburing: add documentation for new napi busy polling Stefan Roesch
2023-04-25 18:20 ` [PATCH v9 3/4] liburing: add example programs for napi busy poll Stefan Roesch
2023-04-25 18:20 ` [PATCH v9 4/4] liburing: update changelog with new feature Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b32446d8b259219d69bff81a6ef51c1ad0b64e3.camel@trillion01.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox